Fix tests failing in Gentoo#22166
Open
hageboeck wants to merge 3 commits intoroot-project:masterfrom
Open
Conversation
Test Results 22 files 22 suites 3d 13h 38m 50s ⏱️ Results for commit 3af3584. ♻️ This comment has been updated with latest results. |
hageboeck
force-pushed
the
fixes_Gentoo
branch
3 times, most recently
from
c9428fe to
3af3584
Compare
When ROOT is tested in Gentoo's sandbox, libsandbox is loaded, which fails the test.
When ROOT is installed in the system, invoking just "rootcling" invokes /usr/bin/rootcling. Here, the result of the rootcling target is invoked.
hageboeck
requested review from
bellenot,
guitargeek and
vepadulano
as code owners
The Makefile of old ROOT tests supports reading architecture and platform from the environment. If ARCH or PLATFORM are defined, this breaks, and the Makefile might fail to compile the tests. Here, these variables are unset to ensure that the test compiles in all environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are needed to run ROOT's test suite in Gentoo. The failures are often caused by the fact that ROOT might already be installed in
/usr/local, which can break the test suite, or by the fact that the environment in portages test sandbox is different from what ROOT expects.