[ntuple] Some changes/fixes to better handle feature flags#22135
Open
silverweed wants to merge 3 commits intoroot-project:masterfrom
Open
[ntuple] Some changes/fixes to better handle feature flags#22135silverweed wants to merge 3 commits intoroot-project:masterfrom
silverweed wants to merge 3 commits intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 10h 47m 41s ⏱️ For more details on these failures, see this check. Results for commit 4340c9a. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
ntuple_featureflags
branch
2 times, most recently
from
fe2cdcb to
3a06a94
Compare
jblomer
approved these changes
May 6, 2026
Contributor
jblomer
left a comment
jblomer
left a comment
There was a problem hiding this comment.
LGTM. I'm not sure what the warning signs in the file list next to RNTupleSerialize.cxx and ntuple_compat.cxx refer to though.
Contributor
Author
They will disappear as soon as |
silverweed
force-pushed
the
ntuple_featureflags
branch
from
3a06a94 to
2f32fab
Compare
silverweed
force-pushed
the
ntuple_featureflags
branch
from
2f32fab to
fcef84a
Compare
silverweed
force-pushed
the
ntuple_featureflags
branch
from
fcef84a to
b955505
Compare
silverweed
force-pushed
the
ntuple_featureflags
branch
2 times, most recently
from
f7003a3 to
5b5ef5a
Compare
Also make them usable for both 32-bit and 64-bit integers.
silverweed
force-pushed
the
ntuple_featureflags
branch
from
5b5ef5a to
4340c9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #22132.
Contains some small changes that I could split off #22017 to avoid introducing too much stuff in it.
This PR doesn't introduce any feature flag per se but it makes the code a bit more robust by dropping the assumption that we have no feature flags.
Checklist: