workflows: fix invalid checkout input in pr-trigger - #235
Merged
Conversation
The dispatch-triggers job passed `package_version` to actions/checkout, which is not a valid input. GitHub Actions silently ignored it and fell back to the default checkout, emitting an "Unexpected input(s)" warning such as: Warning: Unexpected input(s) 'package_version', valid inputs are ['repository', 'ref', 'token', 'ssh-key', 'ssh-known-hosts', 'ssh-strict', 'ssh-user', 'persist-credentials', 'path', 'clean', 'filter', 'sparse-checkout', 'sparse-checkout-cone-mode', 'fetch-depth', 'fetch-tags', 'show-progress', 'lfs', 'submodules', 'set-safe-directory', 'github-server-url', 'allow-unsafe-pr-checkout'] Use the correct `ref` input to explicitly check out the PR head commit, which clears the warning and makes the intent explicit. This was working anyway, because the default ref is the merge commit (hence containing the correct files), so technically we could remove it completely. Let's keep it, so intent is clear. Also, we are now fetching pull request HEAD instead of the merge commit [1] [1]: https://github.com/actions/checkout#checkout-pull-request-head-commit-instead-of-merge-commit Signed-off-by: Julien Stephan <jstephan@baylibre.com>
threexc
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dispatch-triggers job passed
package_versionto actions/checkout, which is not a valid input. GitHub Actions silently ignored it and fell back to the default checkout, emitting an "Unexpected input(s)" warning such as:Warning: Unexpected input(s) 'package_version', valid inputs are ['repository', 'ref', 'token', 'ssh-key', 'ssh-known-hosts', 'ssh-strict', 'ssh-user', 'persist-credentials', 'path', 'clean', 'filter', 'sparse-checkout', 'sparse-checkout-cone-mode', 'fetch-depth', 'fetch-tags', 'show-progress', 'lfs', 'submodules', 'set-safe-directory', 'github-server-url', 'allow-unsafe-pr-checkout']
Use the correct
refinput to explicitly check out the PR head commit, which clears the warning and makes the intent explicit.This was working anyway, because the default ref is the merge commit (hence containing the correct files), so technically we could remove it completely. Let's keep it, so intent is clear. Also, we are now fetching pull request HEAD instead of the merge commit 1