Repository navigation
feat(mobile): a first pass at fitting Rill web-admin on phones #9678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dfliess
wants to merge
19
commits into
rilldata:main
Choose a base branch
from
dfliess:dfliess/mobile-first-pass
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
02c5df1
test(web-admin): add a mobile overflow smoke suite
dfliess 604c03e
fix(web-admin): cap fixed widths and fit admin tables on narrow viewp…
dfliess 42e5f75
fix(web-common): let the shared chrome wrap on narrow viewports
dfliess 49a6b6a
fix(web-admin): make the project shell fit phones
dfliess 146472d
fix(explore): stack the explore dashboard on phones
dfliess 4907e21
fix(canvas): let canvas rows shrink below 420px
dfliess 5a1bdbd
fix(web-admin): fit embed shells and markdown on narrow viewports
dfliess 1596433
feat(web-common): make the fullpage chat and project home fit phones
dfliess 7a8b7e8
feat(web-admin): switch Rill Cloud to the real device viewport
dfliess 18f9e6e
fix(chat): make markdown tables content-width on purpose
dfliess 9515885
fix(web-admin): stop capping the viewport zoom
dfliess f208cf6
fix(explore): opt into the phone layout instead of keying it on width
dfliess 3f9b743
fix(web-admin): drop the inert scroll wrapper around the resources table
dfliess 8466cce
fix(web-admin): drop the inert scroll wrappers around the org tables
dfliess a650d97
test(web-admin): keep the mobile smoke suite out of the desktop e2e p…
dfliess 9962b3b
fix(web-admin): don't mount the editor and pivot behind their phone n…
dfliess c387b18
test(web-admin): don't flag overflow a scroll or clip container alrea…
dfliess 3c6e720
fix(time-controls): hide the SuperPill scrollbar
dfliess 495017a
fix(canvas): keep the KPI number on one line beside its sparkline
dfliess File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
web-admin/src/features/access-request/AccessRequestContainer.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
e2eproject declares notestMatch, so Playwright's default**/*.@(spec|test).?(c|m)[jt]s?(x)applies and itstestIgnore: "/setup"does not exclude the new file (checked againstcreateFileMatcherinplaywright/lib/util.jsat the installed 1.59.1). Every test inmobile-smoke.spec.tstherefore runs twice: once here at iPhone 13, and once undere2eat Desktop Chrome's 1280×720, where the iPhone emulation is discarded and the suite starts asserting zero horizontal overflow at desktop width across four routes — a guarantee nothing else in the repo makes, and the opposite of what this comment claims. Thee2eproject needs atestIgnoreformobile-smoke.spec.ts.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with a
testIgnoreon thee2eproject, so the suite only runs inmobile. 70e6731