refactor: establish UIEvents folder feature - #332
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e7487d1ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| { | ||
| "dir": "src/UIEvents", | ||
| "dir": "src/ui-events", |
There was a problem hiding this comment.
Update documentation metadata for the renamed UIEvents folder
After moving this source to src/ui-events, the UIEvents API disappears from the generated documentation: featureSpecs still defines its dirName/sourceDir as UIEvents/src/UIEvents (scripts/unmonorepo/feature-spec.mjs), while docs/utils.js builds apiModules from that path and filters it out when UiEventsTypes.res is not found. Update the metadata or make the documentation tooling derive the new configured source directory so these public modules remain discoverable.
Useful? React with 👍 / 👎.
9e7487d to
3614687
Compare
Tracking issue: #342
Stack context
Part 22 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #331.
Summary
src/UIEventsto the targetsrc/ui-eventsfolderUIEventsfeatureWebAPI.UIEvents -> WebAPI.DOMNodes + WebAPI.File + UIEventsfeatureTemporary state
WebAPI.DOMsource entry remains until its remaining interfaces have been assignedReview focus
Verification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,File,UIEventsnpm run buildnpm testnpm run format:checkgit diff --check