Skip to content

refactor: consolidate Messaging folder feature #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jderochervlk wants to merge 1 commit into from
+13 −33
Open

refactor: consolidate Messaging folder feature #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 13 additions & 33 deletions rescript.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"WebAPI.Fetch": ["WebAPI.Event", "WebAPI.File", "WebAPI.URL", "Fetch"],
"WebAPI.CSSFontLoading": ["WebAPI.Event", "CSSFontLoading"],
"WebAPI.Device": ["WebAPI.Event", "Device"],
"WebAPI.Messaging": ["WebAPI.Event", "WebAPI.File", "Messaging"],
"WebAPI.Crypto": ["WebAPI.DOM", "Crypto"],
"WebAPI.Performance": ["WebAPI.Event", "Performance"],
"WebAPI.ViewTransitions": ["WebAPI.Event", "ViewTransitions"]
Expand Down Expand Up @@ -62,11 +63,20 @@
]
},
{
"dir": "src/ChannelMessaging",
"dir": "src/messaging",

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the moved messaging modules in the API docs

When Astro generates the API reference, docs/utils.js:85-92 derives each source directory from featureSpecs, which still lists ChannelMessaging, Notification, Push, and WebSockets (scripts/unmonorepo/feature-spec.mjs:77,95,99,113). After moving those files into src/messaging, none of their expected *Types.res paths exist, so the filter silently drops all four API groups and their public modules—including MessagePort, Notification, the Push modules, and WebSocket—from the generated routes and index. Update the documentation metadata/path handling as part of this move.

Useful? React with 👍 / 👎.

"subdirs": true,
"feature": "WebAPI.ChannelMessaging",
"feature": "Messaging",
"public": [
"MessagePort"
"ApplicationServerKey",
"CloseEvent",
"MessageEvent",
"MessagePort",
"Notification",
"PushEvent",
"PushManager",
"PushMessageData",
"PushSubscription",
"WebSocket"
]
},
{
Expand Down Expand Up @@ -351,14 +361,6 @@
"MutationObserver"
]
},
{
"dir": "src/Notification",
"subdirs": true,
"feature": "WebAPI.Notification",
"public": [
"Notification"
]
},
{
"dir": "src/performance",
"subdirs": true,
Expand All @@ -385,18 +387,6 @@
"PictureInPicture"
]
},
{
"dir": "src/Push",
"subdirs": true,
"feature": "WebAPI.Push",
"public": [
"ApplicationServerKey",
"PushEvent",
"PushManager",
"PushMessageData",
"PushSubscription"
]
},
{
"dir": "src/RemotePlayback",
"subdirs": true,
Expand Down Expand Up @@ -528,16 +518,6 @@
"SubtleCrypto"
]
},
{
"dir": "src/WebSockets",
"subdirs": true,
"feature": "WebAPI.WebSockets",
"public": [
"CloseEvent",
"MessageEvent",
"WebSocket"
]
},
{
"dir": "src/WebSpeech",
"subdirs": true,
Expand Down
0 src/Push/ApplicationServerKey.res → src/messaging/ApplicationServerKey.res
View file
Open in desktop
File renamed without changes.
0 ...hannelMessaging/ChannelMessagingTypes.res → src/messaging/ChannelMessagingTypes.res
View file
Open in desktop
File renamed without changes.
0 src/WebSockets/CloseEvent.res → src/messaging/CloseEvent.res
View file
Open in desktop
File renamed without changes.
0 src/WebSockets/MessageEvent.res → src/messaging/MessageEvent.res
View file
Open in desktop
File renamed without changes.
0 src/ChannelMessaging/MessagePort.res → src/messaging/MessagePort.res
View file
Open in desktop
File renamed without changes.
0 src/Notification/Notification.res → src/messaging/Notification.res
View file
Open in desktop
File renamed without changes.
0 src/Notification/NotificationTypes.res → src/messaging/NotificationTypes.res
View file
Open in desktop
File renamed without changes.
0 src/Push/PushEvent.res → src/messaging/PushEvent.res
View file
Open in desktop
File renamed without changes.
0 src/Push/PushManager.res → src/messaging/PushManager.res
View file
Open in desktop
File renamed without changes.
0 src/Push/PushMessageData.res → src/messaging/PushMessageData.res
View file
Open in desktop
File renamed without changes.
0 src/Push/PushSubscription.res → src/messaging/PushSubscription.res
View file
Open in desktop
File renamed without changes.
0 src/Push/PushTypes.res → src/messaging/PushTypes.res
View file
Open in desktop
File renamed without changes.
0 src/WebSockets/WebSocket.res → src/messaging/WebSocket.res
View file
Open in desktop
File renamed without changes.
0 src/WebSockets/WebSocketsTypes.res → src/messaging/WebSocketsTypes.res
View file
Open in desktop
File renamed without changes.