Skip to content

update examples to new SDK - #5

Open
miwialex wants to merge 1 commit into
mainfrom
rm/sdk-update
Open

update examples to new SDK#5
miwialex wants to merge 1 commit into
mainfrom
rm/sdk-update

Conversation

@miwialex

Copy link
Copy Markdown

examples updated to new SDK

@cal-smith cal-smith left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two nits

Comment thread hello-world/package.json
},
"dependencies": {
"@renderinc/sdk": "^0.5.0"
"@renderinc/sdk": "latest"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll probably want to pin these explicitly, demonstrating good security practices and all that

Comment thread hello-world/README.md
Comment on lines 96 to +98
Any call to `task({ name: ... }, handler)` registers a runnable workflow task.
`task(...)` returns a task definition, which is not callable on its own — pass
it to `ctx.step` to run it.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording nit

Suggested change
Any call to `task({ name: ... }, handler)` registers a runnable workflow task.
`task(...)` returns a task definition, which is not callable on its ownpass
it to `ctx.step` to run it.
Any call to `task({ name: ... }, handler)` registers a workflow task and
returns a task definition, which is not callable on its own. pass it to
`ctx.step` to run it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants