Repository navigation
Correct 0.10.1 news fragments and document REFLEX_BACKEND_START_METHOD - #7646
Conversation
The 7258 fragment described the opposite of what #7304 does (it raises an error for a missing __init__.py instead of loading the app), the repeated headers fragment still claimed client_ip came from the first x-forwarded-for hop after #7614 made that depend on trusted_proxy_hops, and the 7261 fragment belonged to a docs-only change. Add the backend start method variables to the self-hosting docs; they were only described in environment.py. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016T8wWv8bUUSzRHNGpKbSqW
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
[Low impact] The PR appears safe to merge. SummaryClarifies backend settings and cleans up release notes.
Both previous findings are fixed. No new actionable issues were found. Reviews (2) · Last reviewed commit: "Keep the 7258 fragment and scope the sta..." · Reviewed by Greptile |
#7304 ended up passing Granian the configured module target, so the original fragment was accurate. The start method variables are only read on the Granian code paths. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016T8wWv8bUUSzRHNGpKbSqW
Merging this PR will not alter performance1 warning
Comparing |
Requested by Masen · project thread
Type of change
Description
Pre-release cleanup found while auditing the 0.10.1 changelog:
news/7258.bugfix.mdsaid backend apps load even without an__init__.py; fail loudly when the app package has no __init__.py #7304 actually raises a clear error naming the missing file. Rewritten to match.news/+repeated-request-headers.bugfix.mdstill saidrouter.session.client_ipis taken from the firstx-forwarded-forhop; since fix: trust forwarded client IPs only behind configured proxies #7614 that depends ontrusted_proxy_hops. Clause dropped (the fix: trust forwarded client IPs only behind configured proxies #7614 fragment covers it).news/+7261.docs.mdcame from a docs-only change (docs: explain frontend path asset URLs #7467), so it is removed from the reflex package changelog.REFLEX_BACKEND_START_METHOD(perf: preload the app and fork production granian workers #7079, perf: fork the dev backend reload worker instead of using a forkserver #7113) was only described inenvironment.py; the self-hosting page now documents it together withREFLEX_STRICT_HOT_RELOAD.Generated by Claude Code