Skip to content

Correct 0.10.1 news fragments and document REFLEX_BACKEND_START_METHOD - #7646

Merged
masenf merged 2 commits into
mainfrom
claude/project-thread-inn4a7
Oct 23, 2026
Merged

masenf merged 2 commits into
mainfrom
claude/project-thread-inn4a7

Conversation

@masenf

@masenf masenf commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Requested by Masen · project thread

Type of change

  • This change requires a documentation update

Description

Pre-release cleanup found while auditing the 0.10.1 changelog:


Generated by Claude Code

View guided diff Turn on auto-fix

The 7258 fragment described the opposite of what #7304 does (it raises an
error for a missing __init__.py instead of loading the app), the repeated
headers fragment still claimed client_ip came from the first x-forwarded-for
hop after #7614 made that depend on trusted_proxy_hops, and the 7261 fragment
belonged to a docs-only change. Add the backend start method variables to the
self-hosting docs; they were only described in environment.py.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016T8wWv8bUUSzRHNGpKbSqW
@masenf
masenf requested review from a team and Alek99 as code owners October 23, 2026 00:54
@masenf masenf added the skip-changelog For doc/internal changes label Oct 23, 2026 — with Claude
@masenf masenf self-assigned this Oct 23, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread news/7258.bugfix.md Outdated
Comment thread docs/hosting/self-hosting.md Outdated
@greptile-apps

greptile-apps Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Clarifies backend settings and cleans up release notes.

  • Self-hosting docs explain how to choose Granian worker start methods.
  • Package news now describes only the behavior each fragment covers.

Both previous findings are fixed. No new actionable issues were found.

Reviews (2) · Last reviewed commit: "Keep the 7258 fragment and scope the sta..." · Reviewed by Greptile

Comment thread docs/hosting/self-hosting.md Outdated
Comment thread docs/hosting/self-hosting.md Outdated
#7304 ended up passing Granian the configured module target, so the
original fragment was accurate. The start method variables are only read
on the Granian code paths.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016T8wWv8bUUSzRHNGpKbSqW
@codspeed

codspeed Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 9 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 148 untouched benchmarks


Comparing claude/project-thread-inn4a7 (6ea978c) with main (a9b6613)

Open in CodSpeed

@masenf
masenf merged commit 9b97634 into main Oct 23, 2026
129 checks passed
@masenf
masenf deleted the claude/project-thread-inn4a7 branch October 23, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants