feat(#4259): pivot boost plugins to AiResource/agent and AiModelServerAPI - #4260
feat(#4259): pivot boost plugins to AiResource/agent and AiModelServerAPI#4260fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
…rAPI
Migrate the boost workspace from legacy entity kinds (Component/ai-agent,
Resource/ai-model) to the upstream-aligned kinds introduced by the
ai-integrations workspace:
- Agents: Component/ai-agent → AiResource/agent across OGX agent
provider, Kagenti agent provider, and all frontend code
- Models: per-model Resource/ai-model → single AiModelServerAPI entity
with spec.serverType, spec.serverUrl, and spec.models.available[]
- Update AI_ASSET_SPEC_TYPES mapping in isAiAsset.ts as the single
source of truth for kind/type pairs
- Rename categoryMeta entries: ai-agent→agent, ai-model→ai-model-server
with updated label ('Model Servers') and icon (RiServerLine)
- Add Available Models display to SummaryCard for AiModelServerAPI
entities with scrollable list of spec.models.available
- Update fixture YAML: agent uses AiResource/agent, model server entry
is commented out (kind not yet registered in dev backend), remove
ai-tool and vector-store fixture entries
- Update dependsOn refs from component:default/ to airesource:default/
- Update all 10 test files with new kind/type assertions
Closes #4259
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4260 +/- ##
==========================================
- Coverage 59.08% 59.08% -0.01%
==========================================
Files 2452 2452
Lines 98005 98017 +12
Branches 27294 27290 -4
==========================================
+ Hits 57908 57912 +4
- Misses 38543 38551 +8
Partials 1554 1554
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
mareklibra
left a comment
mareklibra
left a comment
There was a problem hiding this comment.
Some more considerations:
- Missing changeset
- Plugin code is updated; openspec/ and some specifications/ still say Component/ai-agent and Resource/ai-model. Issue AC asked for no remaining refs in the workspace.
| @@ -147,7 +147,7 @@ | |||
| }, | |||
| }, | |||
| spec: { | |||
There was a problem hiding this comment.
Upstream AiResource.v1alpha1.agent.schema.json requires instructions (and the agent validator rejects missing/empty values). Once catalog-backend-module-ai-resource-agent is loaded (the intended alignment target), these entities will be rejected.
Please set a non-empty spec.instructions (from config / description fallback / placeholder), and update Kagenti + ai-catalog-fixtures.yaml the same way. Also assert instructions in the provider tests.
| } | ||
|
|
||
| // Build dependsOn relations for handoff targets | ||
| const dependsOn: string[] = []; |
There was a problem hiding this comment.
Prefer spec.handoffs (opaque strings) over spec.dependsOn for agent handoffs.
dependsOn was fine on Component, but the agent AiResource schema/model uses handoffs and does not register dependsOn relation fields. Consider mapping handoffTargets → spec.handoffs (and optionally tools/model → spec.tools/spec.model) to match ai-integrations examples.
| {modelsAvailable.length > 0 && ( | ||
| <Flex direction="column" gap="2"> | ||
| <Text variant="title-small"> | ||
| {`Available Models (${modelsAvailable.length})`} |
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 1:42 PM UTC · Completed 2:00 PM UTC Commit: |
ReviewFindingsMedium
Low
|
fullsend-ai-review
Bot
added
the
requires-manual-review
2 participants
Migrate the boost workspace from legacy entity kinds (Component/ai-agent, Resource/ai-model) to the upstream-aligned kinds introduced by the ai-integrations workspace:
provider, Kagenti agent provider, and all frontend code
with spec.serverType, spec.serverUrl, and spec.models.available[]
source of truth for kind/type pairs
with updated label ('Model Servers') and icon (RiServerLine)
entities with scrollable list of spec.models.available
is commented out (kind not yet registered in dev backend), remove
ai-tool and vector-store fixture entries
Closes #4259
Post-script verification
agent/4259-pivot-entity-kinds)9ff73957b1e59ceca89032ba15af079e17c47087..HEAD)