-
Notifications
You must be signed in to change notification settings - Fork 115
docs(#4223): RHIDP-15302 migration design document #4225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
fullsend-ai-coder
wants to merge
4
commits into
main
Choose a base branch
from
agent/4223-migration-design-doc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+378
−4
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a19b6f6
docs(#4223): RHIDP-15302 migration design document
fullsend-ai-coder[bot] 5c81e97
fix(#4223): apply prettier formatting to migration design doc
fullsend-ai-coder[bot] 4bf0a0d
fix(#4223): address review findings on migration design doc
mareklibra cd1043c
docs(#4223): tighten migration design field rules and API filters
mareklibra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
...oost/openspec/changes/ai-catalog-entity-model/specs/migration-readiness/spec.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,10 +84,12 @@ | |
|
|
||
| ## 8. Migration Readiness Design (P2) — _RHIDP-15258_ | ||
|
|
||
| - [ ] 8.1 Create migration design document with mapping table: current kind/spec.type/annotation → target upstream kind (RHIDP-15302) | ||
| - [ ] 8.2 Document transformation rules for each AI asset category (RHIDP-15302) | ||
| - [ ] 8.3 Identify consumer-facing changes: catalog UI filters, entity refs, API queries (RHIDP-15302) | ||
| - [ ] 8.4 Document backward compatibility strategy (e.g., keep annotation for one major version) (RHIDP-15302) | ||
| > Tasks 8.1-8.4 implemented in [ai-asset-upstream-migration-design.md](../../../specifications/ai-asset-upstream-migration-design.md) via [#4223](https://github.com/redhat-developer/rhdh-plugins/issues/4223). | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] blockquote-formatting-convention The new blockquote does not follow the established bold-label-with-colon pattern used elsewhere in tasks.md (e.g., '> Label: description'). |
||
|
|
||
| - [x] 8.1 Create migration design document with mapping table: current kind/spec.type/annotation → target upstream kind (RHIDP-15302) | ||
| - [x] 8.2 Document transformation rules for each AI asset category (RHIDP-15302) | ||
| - [x] 8.3 Identify consumer-facing changes: catalog UI filters, entity refs, API queries (RHIDP-15302) | ||
| - [x] 8.4 Document backward compatibility strategy (e.g., keep annotation for one major version) (RHIDP-15302) | ||
| - [ ] 8.5 Obtain upstream Backstage maintainer or RHDH architect sign-off on migration document (RHIDP-15302) | ||
| - [ ] 8.6 Document sign-off in spec: reviewer name, role, date, approval status (RHIDP-15302) | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[high] broken cross-reference
The relative link ../../../../specifications/ai-asset-upstream-migration-design.md resolves incorrectly. From spec.md's directory (workspaces/boost/openspec/changes/ai-catalog-entity-model/specs/migration-readiness/), four ../ levels reach workspaces/boost/openspec/, producing a non-existent path. The link needs five ../ levels to reach workspaces/boost/ before descending into specifications/.
Suggested fix: Change the link from ../../../../specifications/ai-asset-upstream-migration-design.md to ../../../../../specifications/ai-asset-upstream-migration-design.md (5 levels up instead of 4).