Repository navigation
Delete deprecated FabricSurface bridge init and stub category (#59438) - #59438
Merged
Merged
Conversation
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127294777. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
…59438) Summary: Pull Request resolved: react#59438 `-[RCTFabricSurface initWithBridge:moduleName:initialProperties:]` has zero callers, and it was the only reader of `bridge.surfacePresenter`. Delete it with the `RCTBridge (RCTSurfacePresenterStub)` category. The proxy accessors stay so existing message sends keep resolving. Changelog: [iOS][Removed] - Remove deprecated `RCTFabricSurface` bridge initializer and `RCTBridge` surface-presenter category Differential Revision: D127294777
christophpurrer
force-pushed
the
export-D127294777
branch
from
October 24, 2026 03:12
528cd71 to
4439c8a
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
…59438) Summary: Pull Request resolved: react#59438 `-[RCTFabricSurface initWithBridge:moduleName:initialProperties:]` has zero callers, and it was the only reader of `bridge.surfacePresenter`. Delete it with the `RCTBridge (RCTSurfacePresenterStub)` category. The proxy accessors stay so existing message sends keep resolving. Changelog: [iOS][Removed] - Remove deprecated `RCTFabricSurface` bridge initializer and `RCTBridge` surface-presenter category Differential Revision: D127294777
christophpurrer
force-pushed
the
export-D127294777
branch
from
October 24, 2026 03:22
4439c8a to
c6ad03c
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
…59438) Summary: Pull Request resolved: react#59438 `-[RCTFabricSurface initWithBridge:moduleName:initialProperties:]` has zero callers, and it was the only reader of `bridge.surfacePresenter`. Delete it with the `RCTBridge (RCTSurfacePresenterStub)` category. The proxy accessors stay so existing message sends keep resolving. Changelog: [iOS][Removed] - Remove deprecated `RCTFabricSurface` bridge initializer and `RCTBridge` surface-presenter category Differential Revision: D127294777
christophpurrer
force-pushed
the
export-D127294777
branch
2 times, most recently
from
October 27, 2026 14:36
2c5136b to
9b350e7
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
…59438) Summary: Pull Request resolved: react#59438 `-[RCTFabricSurface initWithBridge:moduleName:initialProperties:]` has zero callers, and it was the only reader of `bridge.surfacePresenter`. Delete it with the `RCTBridge (RCTSurfacePresenterStub)` category. The proxy accessors stay so existing message sends keep resolving. Changelog: [iOS][Removed] - Remove deprecated `RCTFabricSurface` bridge initializer and `RCTBridge` surface-presenter category Differential Revision: D127294777
Visual regressionNo visual differences at |
christophpurrer
force-pushed
the
export-D127294777
branch
from
October 27, 2026 22:24
9b350e7 to
9b34616
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
…59438) Summary: Pull Request resolved: react#59438 `-[RCTFabricSurface initWithBridge:moduleName:initialProperties:]` has zero callers, and it was the only reader of `bridge.surfacePresenter`. Delete it with the `RCTBridge (RCTSurfacePresenterStub)` category. The proxy accessors stay so existing message sends keep resolving. Changelog: [iOS][Removed] - Remove deprecated `RCTFabricSurface` bridge initializer and `RCTBridge` surface-presenter category Reviewed By: andrewdacenko Differential Revision: D127294777
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2026
…59438) Summary: Pull Request resolved: react#59438 `-[RCTFabricSurface initWithBridge:moduleName:initialProperties:]` has zero callers, and it was the only reader of `bridge.surfacePresenter`. Delete it with the `RCTBridge (RCTSurfacePresenterStub)` category. The proxy accessors stay so existing message sends keep resolving. Changelog: [iOS][Removed] - Remove deprecated `RCTFabricSurface` bridge initializer and `RCTBridge` surface-presenter category Reviewed By: andrewdacenko Differential Revision: D127294777
christophpurrer
force-pushed
the
export-D127294777
branch
from
October 27, 2026 23:06
9b34616 to
ee5dcf5
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
…59438) Summary: Pull Request resolved: react#59438 `-[RCTFabricSurface initWithBridge:moduleName:initialProperties:]` has zero callers, and it was the only reader of `bridge.surfacePresenter`. Delete it with the `RCTBridge (RCTSurfacePresenterStub)` category. The proxy accessors stay so existing message sends keep resolving. Changelog: [iOS][Removed] - Remove deprecated `RCTFabricSurface` bridge initializer and `RCTBridge` surface-presenter category Reviewed By: andrewdacenko Differential Revision: D127294777
christophpurrer
force-pushed
the
export-D127294777
branch
from
October 28, 2026 14:48
ee5dcf5 to
e5a75d4
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
…59438) Summary: Pull Request resolved: react#59438 `-[RCTFabricSurface initWithBridge:moduleName:initialProperties:]` has zero callers, and it was the only reader of `bridge.surfacePresenter`. Delete it with the `RCTBridge (RCTSurfacePresenterStub)` category. The proxy accessors stay so existing message sends keep resolving. Changelog: [iOS][Removed] - Remove deprecated `RCTFabricSurface` bridge initializer and `RCTBridge` surface-presenter category Reviewed By: andrewdacenko Differential Revision: D127294777
christophpurrer
force-pushed
the
export-D127294777
branch
from
October 28, 2026 15:20
e5a75d4 to
8d83abc
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 28, 2026
…59438) Summary: Pull Request resolved: react#59438 `-[RCTFabricSurface initWithBridge:moduleName:initialProperties:]` has zero callers, and it was the only reader of `bridge.surfacePresenter`. Delete it with the `RCTBridge (RCTSurfacePresenterStub)` category. The proxy accessors stay so existing message sends keep resolving. Changelog: [iOS][Removed] - Remove deprecated `RCTFabricSurface` bridge initializer and `RCTBridge` surface-presenter category Reviewed By: andrewdacenko Differential Revision: D127294777
christophpurrer
force-pushed
the
export-D127294777
branch
from
October 28, 2026 15:28
8d83abc to
0ae21e1
Compare
christophpurrer
force-pushed
the
export-D127294777
branch
from
October 29, 2026 21:52
0ae21e1 to
e6de759
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 30, 2026
…59438) Summary: Pull Request resolved: react#59438 `-[RCTFabricSurface initWithBridge:moduleName:initialProperties:]` has zero callers, and it was the only reader of `bridge.surfacePresenter`. Delete it with the `RCTBridge (RCTSurfacePresenterStub)` category. The proxy accessors stay so existing message sends keep resolving. Changelog: [iOS][Removed] - Remove deprecated `RCTFabricSurface` bridge initializer and `RCTBridge` surface-presenter category Reviewed By: andrewdacenko Differential Revision: D127294777
christophpurrer
force-pushed
the
export-D127294777
branch
from
October 30, 2026 04:32
e6de759 to
b5cfd57
Compare
andrewdacenko
approved these changes
Oct 30, 2026
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 30, 2026
…59438) Summary: `-[RCTFabricSurface initWithBridge:moduleName:initialProperties:]` has zero callers, and it was the only reader of `bridge.surfacePresenter`. Delete it with the `RCTBridge (RCTSurfacePresenterStub)` category. The proxy accessors stay so existing message sends keep resolving. Changelog: [iOS][Removed] - Remove deprecated `RCTFabricSurface` bridge initializer and `RCTBridge` surface-presenter category Reviewed By: andrewdacenko Differential Revision: D127294777
christophpurrer
force-pushed
the
export-D127294777
branch
from
October 30, 2026 19:20
b5cfd57 to
edad0ad
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 30, 2026
…59438) Summary: `-[RCTFabricSurface initWithBridge:moduleName:initialProperties:]` has zero callers, and it was the only reader of `bridge.surfacePresenter`. Delete it with the `RCTBridge (RCTSurfacePresenterStub)` category. The proxy accessors stay so existing message sends keep resolving. Changelog: [iOS][Removed] - Remove deprecated `RCTFabricSurface` bridge initializer and `RCTBridge` surface-presenter category Reviewed By: andrewdacenko Differential Revision: D127294777
christophpurrer
force-pushed
the
export-D127294777
branch
from
October 30, 2026 19:25
edad0ad to
3156388
Compare
…59438) Summary: `-[RCTFabricSurface initWithBridge:moduleName:initialProperties:]` has zero callers, and it was the only reader of `bridge.surfacePresenter`. Delete it with the `RCTBridge (RCTSurfacePresenterStub)` category. The proxy accessors stay so existing message sends keep resolving. Changelog: [iOS][Removed] - Remove deprecated `RCTFabricSurface` bridge initializer and `RCTBridge` surface-presenter category Reviewed By: andrewdacenko Differential Revision: D127294777
christophpurrer
force-pushed
the
export-D127294777
branch
from
October 30, 2026 21:47
3156388 to
f7c1897
Compare
Collaborator
|
This pull request was successfully merged by @christophpurrer in d4fee6d When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
-[RCTFabricSurface initWithBridge:moduleName:initialProperties:]has zero callers, and it was the only reader ofbridge.surfacePresenter. Delete it with theRCTBridge (RCTSurfacePresenterStub)category. The proxy accessors stay so existing message sends keep resolving.Changelog:
[iOS][Removed] - Remove deprecated
RCTFabricSurfacebridge initializer andRCTBridgesurface-presenter categoryReviewed By: andrewdacenko
Differential Revision: D127294777