Skip to content

fix(ios): make the unmountChildComponentView assert message bounds-safe #57865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dongdongbh wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

fix(ios): make the unmountChildComponentView assert message bounds-safe #57865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,15 +255,16 @@ - (void)unmountChildComponentView:(UIView<RCTComponentViewProtocol> *)childCompo
childComponentView,
@(index),
@([childComponentView.superview tag]));
NSArray<UIView *> *containerSubviews = self.currentContainerView.subviews;
BOOL isIndexInBounds = index >= 0 && (NSUInteger)index < containerSubviews.count;
RCTAssert(
(self.currentContainerView.subviews.count > index) &&
[self.currentContainerView.subviews objectAtIndex:index] == childComponentView,
isIndexInBounds && [containerSubviews objectAtIndex:index] == childComponentView,
@"Attempt to unmount a view which has a different index. (parent: %@, child: %@, index: %@, actual index: %@, tag at index: %@)",
self,
childComponentView,
@(index),
@([self.currentContainerView.subviews indexOfObject:childComponentView]),
@([[self.currentContainerView.subviews objectAtIndex:index] tag]));
@([containerSubviews indexOfObject:childComponentView]),
isIndexInBounds ? @([[containerSubviews objectAtIndex:index] tag]) : @"out of bounds");
}

[childComponentView removeFromSuperview];
Expand Down