Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,15 @@
"build": "npm run docs:build",
"docs:build": "dumi build",
"docs:deploy": "gh-pages -d docs-dist",
"compile": "father build && lessc assets/index.less assets/index.css",
"compile": "father build && node scripts/rewrite-esm-imports.js && lessc assets/index.less assets/index.css",
"browser-field": "node scripts/update-browser-field.js",
"gh-pages": "cross-env GH_PAGES=1 npm run docs:build && npm run docs:deploy",
"prepublishOnly": "npm run compile && npm run browser-field && rc-np",
"prepublishOnly": "npm run compile && npm run test:node-exports && npm run browser-field && rc-np",
"lint": "eslint src/ --ext .ts,.tsx,.jsx,.js,.md",
"lint:tsc": "tsc -p tsconfig.json --noEmit",
"prettier": "prettier --write --ignore-unknown .",
"test": "rc-test",
"test:node-exports": "node scripts/test-node-exports.js",
"coverage": "father test --coverage",
"prepare": "husky",
"tsc": "tsc --noEmit"
Expand Down
57 changes: 57 additions & 0 deletions scripts/rewrite-esm-imports.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
const fs = require('node:fs');
const path = require('node:path');

const esDirectory = path.resolve(__dirname, '../es');
const moduleSpecifierPattern = /(\b(?:from|import)\s*(?:\(\s*)?)(['"])(\.\.?\/[^'"]+)\2(\s*\)?)/g;

fs.writeFileSync(path.join(esDirectory, 'package.json'), '{\n "type": "module"\n}\n');

function collectJavaScriptFiles(directory) {
return fs.readdirSync(directory, { withFileTypes: true }).flatMap((entry) => {
const entryPath = path.join(directory, entry.name);

if (entry.isDirectory()) {
return collectJavaScriptFiles(entryPath);
}

return entry.isFile() && entry.name.endsWith('.js') ? [entryPath] : [];
});
}

function resolveModuleSpecifier(filePath, specifier) {
if (path.extname(specifier)) {
return specifier;
}

const absoluteSpecifier = path.resolve(path.dirname(filePath), specifier);
if (fs.existsSync(`${absoluteSpecifier}.js`)) {
return `${specifier}.js`;
}
if (fs.existsSync(path.join(absoluteSpecifier, 'index.js'))) {
return `${specifier}/index.js`;
}

throw new Error(`Cannot resolve ${specifier} from ${path.relative(esDirectory, filePath)}`);
}

let rewriteCount = 0;

collectJavaScriptFiles(esDirectory).forEach((filePath) => {
const source = fs.readFileSync(filePath, 'utf8');
const rewrittenSource = source.replace(
moduleSpecifierPattern,
(match, prefix, quote, specifier, suffix) => {
const rewrittenSpecifier = resolveModuleSpecifier(filePath, specifier);
if (rewrittenSpecifier !== specifier) {
rewriteCount += 1;
}
return `${prefix}${quote}${rewrittenSpecifier}${quote}${suffix}`;
},
);

if (rewrittenSource !== source) {
fs.writeFileSync(filePath, rewrittenSource);
}
});

console.log(`Rewrote ${rewriteCount} ESM module specifiers.`);
46 changes: 46 additions & 0 deletions scripts/test-node-exports.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
const assert = require('node:assert/strict');

const entryPoints = [
'@rc-component/picker',
'@rc-component/picker/generate',
'@rc-component/picker/generate/moment',
'@rc-component/picker/interface',
'@rc-component/picker/locale/en_US',
'@rc-component/picker/lib/generate',
'@rc-component/picker/lib/generate/moment',
'@rc-component/picker/lib/interface',
'@rc-component/picker/lib/locale/en_US',
'@rc-component/picker/es/generate',
'@rc-component/picker/es/generate/moment',
'@rc-component/picker/es/interface',
'@rc-component/picker/es/locale/en_US',
];

async function testNodeExports() {
const commonJSModules = entryPoints.map((entryPoint) => require(entryPoint));
const esModules = await Promise.all(entryPoints.map((entryPoint) => import(entryPoint)));

assert.equal(commonJSModules.length, entryPoints.length);
assert.equal(esModules.length, entryPoints.length);
Comment thread
coderabbitai[bot] marked this conversation as resolved.

const publicKeys = (module) =>
Object.keys(module)
.filter((key) => key !== '__esModule' && key !== 'module.exports')
.sort();

commonJSModules.forEach((commonJSModule, index) => {
assert.deepEqual(publicKeys(esModules[index]), publicKeys(commonJSModule));
});

assert.equal(esModules[0].default, esModules[0].Picker);
assert.equal(commonJSModules[0].default, commonJSModules[0].Picker);
assert.equal(typeof esModules[2].default.getNow, 'function');
assert.equal(typeof commonJSModules[2].default.getNow, 'function');
assert.equal(esModules[4].default.locale, 'en_US');
assert.equal(commonJSModules[4].default.locale, 'en_US');
}

testNodeExports().catch((error) => {
console.error(error);
process.exitCode = 1;
});