Skip to content

fix(locale): correct fr_BE date selection prompt - #1003

Open
nrps9909 wants to merge 1 commit into
react-component:masterfrom
nrps9909:codex/fix-fr-be-date-select
Open

fix(locale): correct fr_BE date selection prompt#1003
nrps9909 wants to merge 1 commit into
react-component:masterfrom
nrps9909:codex/fix-fr-be-date-select

Conversation

@nrps9909

@nrps9909 nrps9909 commented Aug 26, 2026

Copy link
Copy Markdown

Summary

  • change the Belgian French dateSelect prompt from the duplicated time prompt to Sélectionner la date
  • add a focused locale regression that verifies the date prompt and time prompt stay distinct

Verification

  • exact base: 16084b6a1593d8815a6ae65cba4e6f7ce8d48c9a
  • regression before the fix: tests/locale.spec.ts received Sélectionner l’heure instead of Sélectionner la date
  • pnpm test --runInBand — 16 suites, 469 passed, 2 skipped, 29 snapshots passed
  • pnpm lint — 0 errors, 16 pre-existing hook warnings
  • pnpm compile — ESM/CJS declarations and Less compilation passed
  • git diff --check — passed

pnpm lint:tsc reports 10 removed Jest matcher aliases such as toBeCalled in the existing tests/picker.spec.tsx. I reproduced the identical errors in an isolated worktree at the unmodified exact base, so they are not introduced by this locale change.

Fixes #430

AI assistance disclosure: Codex was used to confirm the current locale value, compare the established French translation, and draft the regression. The mismatch was reproduced on the exact base and all listed checks were run locally.

Summary by CodeRabbit

  • 错误修复
    • 修正比利时法语本地化中的日期选择提示,将“选择时间”更正为“选择日期”。
  • 测试
    • 新增验证,确保日期选择与时间选择提示文案正确区分。

@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

@nrps9909 is attempting to deploy a commit to the afc163's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 14a29b5e-e33c-4f39-befe-da2527da0324

📥 Commits

Reviewing files that changed from the base of the PR and between 16084b6 and 3bd72ce.

📒 Files selected for processing (2)
  • src/locale/fr_BE.ts
  • tests/locale.spec.ts

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

修正 fr_BE locale 的 dateSelect 文案,并新增测试,确认日期提示为“Sélectionner la date”且不同于 timeSelect

Changes

fr_BE 本地化修正

Layer / File(s) Summary
日期提示文案与测试
src/locale/fr_BE.ts, tests/locale.spec.ts
dateSelect 从时间提示改为“Sélectionner la date”。测试验证日期提示文本及其与 timeSelect 的差异。

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 3bd72

This localized change corrects the Belgian French date-selection prompt while preserving a distinct time prompt, with focused regression coverage and passing validation checks; no actionable merge-blocking risk remains.

Poem

小兔看见日期文案变清楚,
“Sélectionner la date”轻轻跳出。
时间提示不再混淆,
测试守在旁边点头,
法语日历开心转圈。

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed PR 完成了 Issue #430 的要求。fr_BE.dateSelect 已更新为 Sélectionner la date,并新增回归测试以验证日期提示与时间提示不同。
Out of Scope Changes check ✅ Passed 所有变更都与 Issue #430 相关。代码仅更新 fr_BEdateSelect 文案,并添加对应测试。未发现范围外变更。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确概括了主要变更:修正 fr_BE locale 的日期选择提示。标题简洁、明确,并与代码和测试变更一致。
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fr_BE dateSelect translation shows "pick a time"

1 participant