Skip to content

Restore Delta direction after reverse application errors - #658

Open
HocVoNgThai wants to merge 1 commit into
qlustered:devfrom
HocVoNgThai:fix/delta-reverse-error
Open

HocVoNgThai wants to merge 1 commit into
qlustered:devfrom
HocVoNgThai:fix/delta-reverse-error

Conversation

@HocVoNgThai

Copy link
Copy Markdown

If t2 - delta raises during application, the temporary forward/reverse diff swap is left in place. For a Delta changing counter from 1 to 2, rejecting a reverse input of 9 causes a later valid forward input of 1 to fail as well.

Restore the original direction in a finally block. The invalid input still raises, while valid forward and reverse applications work afterward. Adds a regression covering both directions after the failure.

Closes #657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant