Skip to content

fix: add c3x and c4x to REV_CTRL_GATE_MAP - #458

Merged
TheGupta2012 merged 2 commits into
qBraid:mainfrom
Riiocodee:fix-rev-ctrl-gate-map
Oct 19, 2026
Merged

TheGupta2012 merged 2 commits into
qBraid:mainfrom
Riiocodee:fix-rev-ctrl-gate-map

Conversation

@Riiocodee

Copy link
Copy Markdown
Contributor

Summary of changes

Fixes #322

REV_CTRL_GATE_MAP lacked entries for c3x and c4x, so _mpl_draw_gate raised NotImplementedError when drawing those gates. Adding the reverse mappings lets the matplotlib printer resolve them to their base gates.

Changes:

Testing:

  • The new regression tests fail without the two map entries and pass with them.
  • Full suite: 1011 passed, 3 skipped.
  • black --check src tests and isort --check-only src tests passed.

AI use: AI-assisted. I used an AI tool to help with the implementation and tests, and I reviewed and tested the final result myself.

I confirm this contribution complies with the Developer's Certificate of Origin.

@argus-eye

argus-eye Bot commented Oct 19, 2026

Copy link
Copy Markdown

Argus review

Auto-review is off for this repo. Tick the box below to run a review on this PR.

  • Trigger Argus review

Estimated cost

  • Files changed: 3
  • Diff lines (±): 34
  • Historical avg: ~350.7k tokens · ~$1.38 · across last 13 review(s)

Tip: you can also comment @argus-eye review at any time.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: qBraid/pyqasm/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6c398844-620d-4ebb-8faa-4825fd6fa7fa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread CHANGELOG.md Outdated
@TheGupta2012
TheGupta2012 self-requested a review October 19, 2026 15:09
@TheGupta2012
TheGupta2012 merged commit 62b012e into qBraid:main Oct 19, 2026
13 checks passed
@Riiocodee
Riiocodee deleted the fix-rev-ctrl-gate-map branch October 19, 2026 18:50
@Riiocodee
Riiocodee restored the fix-rev-ctrl-gate-map branch October 19, 2026 21:44
@Riiocodee
Riiocodee deleted the fix-rev-ctrl-gate-map branch October 19, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

REV_CTRL_GATE_MAP missing mirror entries for c3x/c4x breaks matplotlib printer

3 participants