Skip to content

Arm backend: Reject unsupported comparisons in FP profile - #22558

Merged
Sebastian-Larsson merged 1 commit into
pytorch:mainfrom
Sebastian-Larsson:reject_unsupported_comp_in_fp
Sep 4, 2026
Merged

Arm backend: Reject unsupported comparisons in FP profile#22558
Sebastian-Larsson merged 1 commit into
pytorch:mainfrom
Sebastian-Larsson:reject_unsupported_comp_in_fp

Conversation

@Sebastian-Larsson

@Sebastian-Larsson Sebastian-Larsson commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

TOSA section 2.8 limits PRO-FP comparison inputs to fp16 and fp32, with bf16 provided by EXT-BF16.

Allow int8 and int16 inputs legalized by the preceding pass. Reject other unsupported input types during partitioning so they remain on CPU instead of failing during TOSA lowering.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @robell @rascani

TOSA section 2.8 limits PRO-FP comparison inputs to fp16 and
fp32, with bf16 provided by EXT-BF16.

Allow int8 and int16 inputs legalized by the preceding pass. Reject
other unsupported input types during partitioning so they remain on CPU
instead of failing during TOSA lowering.

Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
Change-Id: I3557c9aa1b77fbd903e5736d32a83f6bff9cd181
@Sebastian-Larsson Sebastian-Larsson added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate labels Sep 4, 2026
@pytorch-bot

pytorch-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22558

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit e161e05 with merge base 9036d84 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 4, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Sep 4, 2026
@Sebastian-Larsson
Sebastian-Larsson merged commit 696a144 into pytorch:main Sep 4, 2026
525 of 535 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants