Skip to content

Lower Conv1d atomically through TOSA Conv2d (#22282) - #22282

Open
mcremon-meta wants to merge 1 commit into
mainfrom
export-D116686805
Open

Lower Conv1d atomically through TOSA Conv2d (#22282)#22282
mcremon-meta wants to merge 1 commit into
mainfrom
export-D116686805

Conversation

@mcremon-meta

@mcremon-meta mcremon-meta commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary:

Lower one-dimensional convolutions atomically during convolution rewriting instead of expanding them to rank four in an earlier pass. Emit rank-three layout boundaries around the operation and introduce the singleton spatial dimension only after converting the input to the backend layout.

Rewrite regular and depthwise weights directly into their TOSA Conv2d layouts, and retain the earlier expansion path only for transposed one-dimensional convolutions. This exposes rank-three transforms to the existing layout propagation and cancellation passes while keeping the generated convolution representation valid.

Differential Revision: D116686805

@pytorch-bot

pytorch-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22282

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 45 Pending, 1 Unrelated Failure

As of commit dd3785c with merge base 80f7005 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2026
@meta-codesync

meta-codesync Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116686805.

@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Aug 28, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@rascani

rascani commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

FYI, you'll probably want to rebase and test with #22212 and #22213. The latter is not yet landed. CC @zingo

Summary:

Lower one-dimensional convolutions atomically during convolution rewriting instead of expanding them to rank four in an earlier pass. Emit rank-three layout boundaries around the operation and introduce the singleton spatial dimension only after converting the input to the backend layout.

Rewrite regular and depthwise weights directly into their TOSA Conv2d layouts, and retain the earlier expansion path only for transposed one-dimensional convolutions. This exposes rank-three transforms to the existing layout propagation and cancellation passes while keeping the generated convolution representation valid.

Differential Revision: D116686805
@meta-codesync meta-codesync Bot changed the title Lower Conv1d atomically through TOSA Conv2d Lower Conv1d atomically through TOSA Conv2d (#22282) Aug 28, 2026
@meta-codesync
meta-codesync Bot force-pushed the export-D116686805 branch from 9d1d34a to dd3785c Compare August 28, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants