Lower Conv1d atomically through TOSA Conv2d (#22282) - #22282
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22282
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 45 Pending, 1 Unrelated FailureAs of commit dd3785c with merge base 80f7005 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116686805. |
This PR needs a
|
Summary: Lower one-dimensional convolutions atomically during convolution rewriting instead of expanding them to rank four in an earlier pass. Emit rank-three layout boundaries around the operation and introduce the singleton spatial dimension only after converting the input to the backend layout. Rewrite regular and depthwise weights directly into their TOSA Conv2d layouts, and retain the earlier expansion path only for transposed one-dimensional convolutions. This exposes rank-three transforms to the existing layout propagation and cancellation passes while keeping the generated convolution representation valid. Differential Revision: D116686805
9d1d34a to
dd3785c
Compare
Summary:
Lower one-dimensional convolutions atomically during convolution rewriting instead of expanding them to rank four in an earlier pass. Emit rank-three layout boundaries around the operation and introduce the singleton spatial dimension only after converting the input to the backend layout.
Rewrite regular and depthwise weights directly into their TOSA Conv2d layouts, and retain the earlier expansion path only for transposed one-dimensional convolutions. This exposes rank-three transforms to the existing layout propagation and cancellation passes while keeping the generated convolution representation valid.
Differential Revision: D116686805