Expose Bluetooth HCI socket constants on Linux - #16423
Merged
Merged
Conversation
`HCI_FILTER`, `HCI_TIME_STAMP` and `HCI_DATA_DIR` were only declared for platforms other than Windows, macOS and Linux, so type checkers reported them as missing on Linux even though CPython defines them there whenever it is built with Bluetooth support. The CPython docs list them as unavailable only on NetBSD, DragonFlyBSD and (for the latter two) FreeBSD. Declare them on Linux in `_socket` and `socket`, following the same pattern already used for `BTPROTO_HCI`: the `__all__` entries stay excluded on Linux and the names are added as optional entries to the Linux stubtest allowlist, because the GitHub Actions runners build Python without Bluetooth headers.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HCI_FILTER,HCI_TIME_STAMPandHCI_DATA_DIRare declared only for platforms other than Windows, macOS and Linux, so type checkers report them as missing on Linux even though CPython exposes them there when built with Bluetooth support. The socket docs list them as unavailable only on NetBSD, DragonFlyBSD and, for the latter two, FreeBSD, andsocketmodule.cadds them whenever the macros are defined.Declare them on Linux in
_socketandsocket, following the same pattern already used forBTPROTO_HCI: the__all__entries stay excluded on Linux and the names are added as optional entries to the Linux stubtest allowlist, because the GitHub Actions runners build Python without Bluetooth headers.Related: #15213