Fix cached_property access through classes - #21831
Draft
aryansk wants to merge 1 commit into
Draft
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #21825.
functools.cached_property.__get__returns the descriptor when accessed through a class. Mypy now preserves that behavior for class-level access, while instance access continues to use the cached property's return type. The decorator marker is retained in serialized nodes and the cache format version is bumped so stale caches cannot misinterpret the new field.Evidence
test-data/unit/check-functools.testcovers class access from bothA.valueand a classmethod, including.attrname.uv run --with mypy-extensions --with pytest --with pytest-xdist --with lxml python3 -m pytest -q mypy/test/testcheck.py -k 'check-functools'(31 passed)uv run --with mypy-extensions --with pytest --with filelock --with psutil --with types-psutil --with tomli --with lxml python3 -m mypy --config-file mypy_self_check.ini -p mypy(clean)uv run --with pre-commit pre-commit run --files mypy/checkmember.py mypy/nodes.py mypy/semanal.py mypy/cache.py test-data/unit/check-functools.test(passed)git diff --checkNo maintainer-only, legal, or contributor-account action is required.