Repository navigation
gh-109564: asyncio: drop connections accepted by a closed server - #160851
Merged
asvetlov merged 2 commits intoOct 29, 2026
Merged
Conversation
If Server.close() ran after a connection was accepted but before its transport was created, Server._attach() hit an assertion, the error was reported to the exception handler, and the half-built transport later raised TypeError from __del__. Close such connections quietly instead, in both the selector and proactor accept paths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
asvetlov
requested review from
1st1,
kumaraditya303 and
willingc
as code owners
October 28, 2026 21:00
asvetlov
added
needs backport to 3.14
|
Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-160878 is a backport of this pull request to the 3.15 branch. |
|
GH-160879 is a backport of this pull request to the 3.14 branch. |
asvetlov
added a commit
that referenced
this pull request
Oct 29, 2026
…er (GH-160851) (#160879) gh-109564: asyncio: drop connections accepted by a closed server (GH-160851) If Server.close() ran after a connection was accepted but before its transport was created, Server._attach() hit an assertion, the error was reported to the exception handler, and the half-built transport later raised TypeError from __del__. Close such connections quietly instead, in both the selector and proactor accept paths. (cherry picked from commit 5364bdc) Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
asvetlov
added a commit
that referenced
this pull request
Oct 29, 2026
…er (GH-160851) (#160878) gh-109564: asyncio: drop connections accepted by a closed server (GH-160851) If Server.close() ran after a connection was accepted but before its transport was created, Server._attach() hit an assertion, the error was reported to the exception handler, and the half-built transport later raised TypeError from __del__. Close such connections quietly instead, in both the selector and proactor accept paths. (cherry picked from commit 5364bdc) Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
Server.close()runs after a connection was accepted but before its transport is created,Server._attach()hitsassert self._sockets is not None. The selector loop reports theAssertionErrorto the exception handler, and the half-built transport later raisesTypeErrorfrom__del__(Server._wakeup()with_waitersalreadyNone). On the proactor loop the exception escapes the accept callback and the accepted socket leaks.Both accept paths now close such a connection quietly before the transport is created. SSL connections go through the same path.
The regression test closes the server from the protocol factory, which forces this ordering deterministically on both selector and proactor loops. It fails without the fix on Linux and Windows.
This overlaps with #154861, which guards only the selector path.
🤖 Generated with Claude Code