Skip to content

gh-82151: Update and improve urlsplit docstring#152985

Merged
orsenthil merged 2 commits into
python:mainfrom
pranavchoudhary-tech:fix-urllib-parse-docs
Jul 6, 2026
Merged

gh-82151: Update and improve urlsplit docstring#152985
orsenthil merged 2 commits into
python:mainfrom
pranavchoudhary-tech:fix-urllib-parse-docs

Conversation

@pranavchoudhary-tech

@pranavchoudhary-tech pranavchoudhary-tech commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

This PR supersedes and finishes the work started in #18631 by @idomic.

It applies the final wording changes requested by the maintainers in the original PR review to clarify the urlsplit return components.

Closes #82151.

@read-the-docs-community

read-the-docs-community Bot commented Jul 3, 2026

Copy link
Copy Markdown

Co-authored-by: idomic <michael.ido@gmail.com>

@orsenthil orsenthil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This will close the long discussions in the referenced issue, and follows the recommendation from that thread.

@orsenthil orsenthil added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 6, 2026
@orsenthil orsenthil merged commit ad54b91 into python:main Jul 6, 2026
40 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @pranavchoudhary-tech for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jul 6, 2026
@miss-islington-app

Copy link
Copy Markdown

Sorry, @pranavchoudhary-tech and @orsenthil, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ad54b91b9fa4c5d12f155bb09138dff21a2bdec3 3.14

@bedevere-app

bedevere-app Bot commented Jul 6, 2026

Copy link
Copy Markdown

GH-153154 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 6, 2026
@miss-islington-app

Copy link
Copy Markdown

Sorry, @pranavchoudhary-tech and @orsenthil, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ad54b91b9fa4c5d12f155bb09138dff21a2bdec3 3.13

@bedevere-app

bedevere-app Bot commented Jul 6, 2026

Copy link
Copy Markdown

GH-153155 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 6, 2026
@bedevere-app

bedevere-app Bot commented Jul 6, 2026

Copy link
Copy Markdown

GH-153156 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 6, 2026
@orsenthil

Copy link
Copy Markdown
Member

@pranavchoudhary-tech , do you know why the CLA is not showing up in the branches ? Could you please make sure they are signed.

Thank you.

@pranavchoudhary-tech

Copy link
Copy Markdown
Contributor Author

Hi @orsenthil! Thank you for merging this! Regarding the CLA, my CLA is signed (which is why the main PR check passed). It looks like the backport branches failed for the older versions due to a merge conflict (as noted by miss-islington), rather than a CLA issue. If any backport PRs are failing a CLA check, it might be because the original author (@idomic) who I co-authored with hasn't signed it for those specific branches, though it passed on main. Let me know if you'd like me to manually backport these using cherry_picker and resolve the conflicts!

@pranavchoudhary-tech

Copy link
Copy Markdown
Contributor Author

@orsenthil @StanFromIreland Update: I realized the issue was because I force-pushed a minor tweak from a different machine and that secondary email wasn't linked to my CLA. I have just signed the CLA for that email! The CLA checks should be green now. Apologies for the confusion!

orsenthil added a commit that referenced this pull request Jul 7, 2026
…3155)

gh-82151: Update and improve urlsplit docstring (#152985)



Slightly improved wording for % escapes. Consistent with rest of the doc.

---------



(cherry picked from commit ad54b91)

Co-authored-by: Pranav Choudhary <chaudharyypranav@gmail.com>
Co-authored-by: idomic <michael.ido@gmail.com>
orsenthil added a commit that referenced this pull request Jul 7, 2026
…153154)

gh-82151: Update and improve urlsplit docstring (GH-152985)

(cherry picked from commit ad54b91)

Co-authored-by: Pranav Choudhary <chaudharyypranav@gmail.com>
Co-authored-by: idomic <michael.ido@gmail.com>
Co-authored-by: Senthil Kumaran <senthil@python.org>
orsenthil added a commit that referenced this pull request Jul 7, 2026
…3156)

gh-82151: Update and improve urlsplit docstring (#152985)

(cherry picked from commit ad54b91)

Co-authored-by: Pranav Choudhary <chaudharyypranav@gmail.com>
Co-authored-by: idomic <michael.ido@gmail.com>
Co-authored-by: Senthil Kumaran <senthil@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

urllib.parse docstrings incomplete

2 participants