gh-82151: Update and improve urlsplit docstring#152985
Conversation
Documentation build overview
13 files changed ·
|
Co-authored-by: idomic <michael.ido@gmail.com>
5a0d347 to
71c8700
Compare
orsenthil
left a comment
There was a problem hiding this comment.
LGTM.
This will close the long discussions in the referenced issue, and follows the recommendation from that thread.
|
Thanks @pranavchoudhary-tech for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
Sorry, @pranavchoudhary-tech and @orsenthil, I could not cleanly backport this to |
|
GH-153154 is a backport of this pull request to the 3.15 branch. |
|
Sorry, @pranavchoudhary-tech and @orsenthil, I could not cleanly backport this to |
|
GH-153155 is a backport of this pull request to the 3.14 branch. |
|
GH-153156 is a backport of this pull request to the 3.13 branch. |
|
@pranavchoudhary-tech , do you know why the CLA is not showing up in the branches ? Could you please make sure they are signed. Thank you. |
|
Hi @orsenthil! Thank you for merging this! Regarding the CLA, my CLA is signed (which is why the main PR check passed). It looks like the backport branches failed for the older versions due to a merge conflict (as noted by miss-islington), rather than a CLA issue. If any backport PRs are failing a CLA check, it might be because the original author (@idomic) who I co-authored with hasn't signed it for those specific branches, though it passed on main. Let me know if you'd like me to manually backport these using |
|
@orsenthil @StanFromIreland Update: I realized the issue was because I force-pushed a minor tweak from a different machine and that secondary email wasn't linked to my CLA. I have just signed the CLA for that email! The CLA checks should be green now. Apologies for the confusion! |
This PR supersedes and finishes the work started in #18631 by @idomic.
It applies the final wording changes requested by the maintainers in the original PR review to clarify the
urlsplitreturn components.Closes #82151.