-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
gh-149902: Remove dead packaging docs link and add a new secition for external resources #150030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
miameows
wants to merge
6
commits into
python:main
Choose a base branch
from
miameows:fix-packaging-docs-link
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
−2
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cabca53
Remove link to unused distribution docs page
miameows 314a97e
Add "Other resources" section to docs front page
miameows 26a0478
Remove /en/latest from links in "Other Resources" section of docs
miameows 265ab70
Remove extra newline from docs index
miameows 94cd6ab
fix docs table typo: widht -> width
miameows 7187979
fix docs table typo: widht -> width
miameows File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this we'll have two "Other resources" sections, one in the sidebar and one here, why not add these to the existing one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Other resources" section also has two links to the deprecated Python wiki, maybe we should drop those and link to packaging.python.org and typing.python.org instead.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need both "Other resources" sections?
If yes, should they both contain the same things?
If not, which shall we remlve?
Perhaps the wiki books link could be replaced with
https://www.pythondiscord.com/resources/?type=book or https://pythonbooks.org/ ?
See also #148998 for more general wiki cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor of removing the other section if it links to outdated content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the placement of this new section should be fairly prominent, considering it contains a link that was (indirectly) already featured front and center. I think it's helpful to have a "signpost" of sorts so users who do a web search for "Python documentation" can easily find related resources without having to look at the small text in the sidebar. I'm of the opinion that sidebars are for navigation of complex hierarchies, not holding content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the sidebar is serving two purposes now which could be confusing. If straightening that out expands the scope too much, we can continue the discussion in a subsequent PR.