Strip indentation of release dashboard HTML - #798
Merged
Merged
Conversation
hugovk
changed the title
hugovk
force-pushed
the
strip-indentation
branch
from
September 22, 2026 14:40
a5adb35 to
0866ca1
Compare
zware
approved these changes
Oct 1, 2026
zware
left a comment
zware
left a comment
Member
There was a problem hiding this comment.
I wonder about stripping the template itself (once) before passing it along to flask, but this looks good as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release dashboard is big, about 12 MB of raw HTML.
The template is heavily indented, which is very good for readability.
But this results in over half the generated page being whitespace.
If we strip indentation, this gets us down to around 5.4 MB, making it around 55% smaller.
Stripping the leading indent from the generated page should reduce the page load time from around 7s to 4s.
I've also opened a PR to enable gzip compression on the nginx server (python/psf-salt#655), which should do a very good job of compressing repeated whitespace, so this PR won't have as big as an effect, maybe half a second or so.
But there's still a benefit: half the data to send from Twisted to nginx and compress, half to keep in the browser cache, and a bit less parsing in the browser.
Easy to disable for local dev/testing of the dashboard if needing to inspect actual HTML.