perf: Query distro.version sources lazily#379
Open
ichard26 wants to merge 1 commit into
Open
Conversation
When /etc/os-release provides sufficiently high-quality version information directly, there is no need to call lsb_release in a subprocess or query any other version. This speeds up distro.version() massively when lsb_release is slow to execute, like on Ubuntu 26.04 LTS where it can easily take north of 15ms. For context, pip uses distro.version() to populate its user-agent header so we'd like this function to be as fast as reasonably possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I first wanted to say thanks for maintaining distro. From the pip team, we appreciate it!
When
/etc/os-releaseprovides sufficiently high-quality version information directly, there is no need to calllsb_releasein a subprocess or query any other version.This speeds up distro.version() massively when
lsb_releaseis slow to execute, like on Ubuntu 26.04 LTS where it can easily take north of 15ms.For context, pip uses distro.version() to populate its user-agent header so we'd like this function to be as fast as reasonably possible.
For benchmarking, you can use this which is equivalent to what pip does:
Under CPython 3.15's new sampling profiler on Ubuntu 26.04 LTS: