Defer pygments and pdb imports (9% speedup) - #14874
Open
giampaolo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
pytest currently imports
pygmentsandpdbon every run, even though they are only needed in specific cases:pygmentsis only used when there is a failure, for the summary shown at the end, and only when terminal colors are enabled.pdbis only used with the --pdb CLI option, and only if a test fails.Note: pdb became noticeably more expensive to import in Python 3.14, as it now pulls in
socket,asyncio, andselectorsmodules, which together bring in roughly 40 additional modules.Using this patched pytest version against the psutil test suite (839 tests) with
--plugins-disabledand--collect-only, I see about a 9% speedup:bench_real.py