fix: avoid zero-inode samefile matches on network filesystems - #14866
Closed
aryansk wants to merge 2 commits into
Closed
fix: avoid zero-inode samefile matches on network filesystems#14866aryansk wants to merge 2 commits into
aryansk wants to merge 2 commits into
Conversation
Member
|
duplicate of #14865 |
Author
|
Thanks for pointing me to #14865. I have not reopened or duplicated the fix; this draft is closed and the issue is now covered by the maintainer PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14864
Some network filesystems report
st_ino == 0for every path.samefile_nofollow()now avoids callingsamestat()when either inode is zero, preventing unrelated paths from being treated as the same file. Added regression coverage for all zero-inode combinations.Testing:
PYTHONPATH=src uv run --no-project --python 3.13 --with pytest --with pluggy --with iniconfig --with packaging python -m pytest -q testing/test_pathlib.py -k "samefile_nofollow or samefile_false_negatives"Prepared with AI assistance; maintainer review is requested.