Conversation
port19x
changed the title
Co-authored-by: Werryx <53448668+Werryx@users.noreply.github.com>
|
Thanks @Werryx |
|
Also @Derisis13 you randomly added the claude killstring in #1627 |
|
Closing for now, this needs more work in the issue stage |
port19x
changed the title
|
Lgtm |
justchokingaround
left a comment
justchokingaround
left a comment
There was a problem hiding this comment.
the rest looks good, I'm highly in favor of this PR 👍
| ### Coding Tips | ||
|
|
||
| - Keep it brief. Your likelihood of being merged is inversely proportional to your change size. | ||
| - Use && and || over if-else constructs whereever appropriate |
There was a problem hiding this comment.
*wherever
and also I'd link to this video, I think it's a rly good explanation that many people don't get: https://www.youtube.com/watch?v=p0KKBmfiVl0
| - Add the AI model as a coauthor | ||
| - Using LLMs as a better search engine is okay | ||
| - Using LLMs to remember syntax and idioms is okay | ||
| - Using LLMs to verify posix compliance is okay |
There was a problem hiding this comment.
id say rather to refactor into posix compliance ig, bc for posix compliance u should only use shellcheck which is deterministic
There was a problem hiding this comment.
shellcheck is non-exhaustive with utilities tho, but I can see how that would be covered by "refactor"
| Add these two urls into the context, however you do that with your LLM of choice: | ||
| - https://github.com/pystardust/ani-cli/blob/master/.github/workflows/ani-cli.yml | ||
| - https://github.com/pystardust/ani-cli/blob/master/CONTRIBUTING.md | ||
|
|
There was a problem hiding this comment.
id prefer saying that u should add these two files, not urls, so that people can also figure out that they have them locally as well easier
There was a problem hiding this comment.
would files/urls work?
|
@justchokingaround if you want to make a PR with your suggestions I'll merge for sure, otherwise I can make one sometime this week |
5 participants
Pull Request Template
Type of change
Description
resolves #1769
WIP