Harden decryption error handling#235
Open
jguz-pubnub wants to merge 3 commits into
Open
Conversation
…urning ciphertext
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…'s hardened SafeLoader can deserialize them
parfeon
approved these changes
Jul 6, 2026
parfeon
left a comment
parfeon
left a comment
Contributor
There was a problem hiding this comment.
Looks good but have small question.
| return self._pubnub.crypto.decrypt(message_input), None | ||
| except Exception as exception: | ||
| logger.warning("could not decrypt message: \"%s\", due to error %s" % (message_input, str(exception))) | ||
| logger.warning("could not decrypt message, due to error %s" % str(exception)) |
Contributor
There was a problem hiding this comment.
Is there a reason to hide message which wasn't decrypted? We can change log level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: raises
PubNubException('decryption error')on failure instead of returning the still-encrypted bytesPubNubFileCrypto.decryptnow raisesPubNubException('decryption error')instead of returning the still-encrypted bytes on failure, so callers can no longer mistake ciphertext for plaintext.fix: return one generic decryption error from cryptors instead of the crypto-library message
Cryptors now return a single generic error on any decryption failure instead of surfacing the underlying crypto-library message. Cause kept in debug logs only.
test: strip dead python-object URL tags from asyncio VCR cassettes so vcrpy's hardened SafeLoader can deserialize them