bdm: added read16/write16 to support large disks#876
Merged
Conversation
Florin9doi
commented
Jun 21, 2026
Florin9doi
commented
Contributor
- more tests are needed
Florin9doi
force-pushed
the
rw16
branch
2 times, most recently
from
June 21, 2026 16:03
53d522c to
527fec8
Compare
Contributor
Author
|
I tested using both of my SATA adapters capable of powering a 3.5 inch drive: a JMicron JMS567 and a JMS578, and both work as expected, including accessing data above the previous 32 bit limit. I have more adapters, but none of them are compatible with 3.5 inch drives, and I don't have any 2.5 inch drive larger than 2TB. Rebased and ready for review |
Florin9doi
marked this pull request as ready for review
July 22, 2026 17:34
rickgaiser
reviewed
Jul 23, 2026
rickgaiser
left a comment
rickgaiser
left a comment
Member
There was a problem hiding this comment.
The SCSI files should be the same. Originally I wanted to have them in a separate library instead of this duplicated code but that's the way they are now. Please compare your changes to both SCSI files and try to keep them as much the same as possible.
Member
|
Ready for merge? |
Contributor
Author
|
Yes, from my point of view |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.