Make same-file duplicate skipping the default, fixes #601 - #602
Open
Nic-Polumeyv wants to merge 2 commits into
Open
Make same-file duplicate skipping the default, fixes #601#602Nic-Polumeyv wants to merge 2 commits into
Nic-Polumeyv wants to merge 2 commits into
Conversation
…ind skipDuplicates: "content"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now implements the default flip from #601: repeated imports of the same file are skipped by default, and the previous content-based skipping moved behind
skipDuplicates: "content".falsestill disables both layers.The same-file layer (
state.importedFiles) already runs for every truthy value, so only the two content-layer checks changed. Flipping the default changes output for projects that relied on content collapsing, so this needs a major.