Skip to content

chore: remove outdated benchmark comparison #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludofischer merged 1 commit into from
Oct 24, 2026
Merged

chore: remove outdated benchmark comparison #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 9 additions & 61 deletions scripts/benchmark/parser-benchmark-worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,68 +14,19 @@ if (typeof sourceRoot !== 'string')
throw new Error('missing parser source root');

const parser = await import(pathToFileURL(`${sourceRoot}/lib/parser.js`).href);
// The candidate builds a closer array with `matchBlocks`; the baseline builds a
// `BlockIndex` with `indexBlocks`. Either is passed to `parse` as the fourth
// argument, so one timed closure serves both.
const closerBuilder = await importOptional(`${sourceRoot}/lib/blocks.js`).then(
(blocks) => blocks && ((tokens) => blocks.matchBlocks(tokens).close)
const { matchBlocks } = await import(
pathToFileURL(`${sourceRoot}/lib/blocks.js`).href
);
const buildCloser =
closerBuilder ??
(await importOptional(`${sourceRoot}/lib/block-index.js`))?.indexBlocks;
if (typeof parser.parse !== 'function')
const buildCloser = (tokens) => matchBlocks(tokens).close;
if (typeof parser.parse !== 'function' || typeof matchBlocks !== 'function')
throw new Error('incompatible baseline parser API');

const TARGET_MS = payload.targetBatchMs ?? 25;
const MIN_WARMUPS = payload.warmupMinimum ?? 5;
const MAX_WARMUPS = payload.warmupMaximum ?? 10;
const MEASURED_BATCHES = payload.measuredBatchCount ?? 6;

/** @param {string} url @return {Promise<any>} undefined when the module is absent */
async function importOptional(url) {
try {
return await import(pathToFileURL(url).href);
} catch (error) {
if (
error instanceof Error &&
'code' in error &&
error.code === 'ERR_MODULE_NOT_FOUND'
) {
return undefined;
}
throw error;
}
}

/**
* Opaque components were nested arrays before the flat representation. Both
* shapes describe the same text, so compare them by their flattened form:
* arrays are spliced in and adjacent strings are merged.
*/
function normalizeTree(value) {
if (value === null || typeof value !== 'object') return value;
if (Array.isArray(value)) return value.map(normalizeTree);
if (value.type === 'OpaqueCall') {
const parts = [];
const pushPart = (part) => {
if (Array.isArray(part)) {
for (const child of part) pushPart(child);
} else if (typeof part === 'string' && typeof parts.at(-1) === 'string') {
parts[parts.length - 1] += part;
} else {
parts.push(normalizeTree(part));
}
};
for (const part of value.components) pushPart(part);
return { ...value, components: parts };
}
return Object.fromEntries(
Object.entries(value).map(([key, child]) => [key, normalizeTree(child)])
);
}

function digest(input) {
const value = normalizeTree(input);
function digest(value) {
const hash = createHash('sha256');
const stack = [value];
while (stack.length) {
Expand Down Expand Up @@ -113,13 +64,10 @@ function consume(value) {

function makeRun(workload) {
const tokens = tokenize({ css: workload.source });
const shared = buildCloser && workload.mode === 'hot-shared-index';
const closer = shared ? buildCloser(tokens) : undefined;
return () => {
if (!buildCloser) return parser.parse(tokens, 0, tokens.length);
const current = closer ?? buildCloser(tokens);
return parser.parse(tokens, 0, tokens.length, current);
};
const closer =
workload.mode === 'hot-shared-index' ? buildCloser(tokens) : undefined;
return () =>
parser.parse(tokens, 0, tokens.length, closer ?? buildCloser(tokens));
}

function timedBatch(run, repetitions) {
Expand Down
Loading