Skip to content

Visor: improve identity glyph visibility and selection contrast - #185

Merged
lannbot merged 2 commits into
mainfrom
visor/identity-glyph-contrast
Sep 8, 2026
Merged

Visor: improve identity glyph visibility and selection contrast#185
lannbot merged 2 commits into
mainfrom
visor/identity-glyph-contrast

Conversation

@lannbot

@lannbot lannbot commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Enlarge the identity circle to 32px with a 20px, weight-600 glyph and unit line height.
  • Use the medium-dark strip-edge shade as its background, with light text; emoji retain their native artwork.
  • Reserve the light selected-half fill for the app side. Settings selection uses a subtle bottom indicator without changing the identity circle.
  • Fix CI-discovered drawer timing: wait for launch dismissal in the test helper, exclude closing panes from settled state, and use a 1ms reduced-motion animation so completion events arrive reliably.

Verification

  • Astra review complete; real-app desktop and mobile screenshots inspected with letters and single-codepoint emoji.
  • just check, just test, and just e2e passed (29 browser scenarios).
  • Extend the existing contrast sweep with a saved letter glyph, check geometry and selection styles, and verify the circle is unchanged across selection transitions.
  • Reduced-motion navigation passed 12 consecutive runs at 8x CPU throttle; mobile layout, contrast, and narrow-layout scenarios each passed 10 consecutive runs.

Dark emoji can still have low contrast against the dark background; no halo or alteration of emoji artwork was added. Physical Android was not tested.

Automerge will be armed.

@lannbot
lannbot enabled auto-merge September 8, 2026 15:02
@lannbot
lannbot disabled auto-merge September 8, 2026 15:28
@lannbot
lannbot enabled auto-merge September 8, 2026 15:56
@lannbot
lannbot merged commit 4621039 into main Sep 8, 2026
2 checks passed
@lannbot
lannbot deleted the visor/identity-glyph-contrast branch September 8, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants