runtime: fix component-model audit findings - #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the ten outstanding correctness findings from the Component Model audit, plus the related borrow-to-own guard:
Regression coverage includes translated components for resource identity/lifetimes, destructor context, future round trips, stream ownership, and all string encoding/tag combinations. Other tests cover cancellation state transitions, byte-buffer retirement, failure cleanup, and harness classification.
Based on current main including #315 and #316. #315 already fixed the audit's delayed task.return finding; its behavior is preserved. Existing documented feature exclusions and named spec divergences are unchanged. No protocol, golden transcript, dependency lock, or package version changes.
Verification
just gates < /dev/null: passed, including packaging/npm, pinned shell lanes, Chromium/Firefox page and worker realms, OPFS, and TLS/C0 consumer smokes. Redirecting stdin matches CI's non-TTY environment for the WASI terminal test.