Skip to content

fix(server): preserve resource monitor executable modes - #8650

Open
only21mil wants to merge 1 commit into
pingdotgg:mainfrom
only21mil:buzz-ci/66738b4f0323a3f867829e7ad1e351300d3acc90
Open

fix(server): preserve resource monitor executable modes#8650
only21mil wants to merge 1 commit into
pingdotgg:mainfrom
only21mil:buzz-ci/66738b4f0323a3f867829e7ad1e351300d3acc90

Conversation

@only21mil

@only21mil only21mil commented Aug 29, 2026

Copy link
Copy Markdown

CI-only mirror of the canonical Buzz resource-monitor candidate

Buzz is the repository of record. This GitHub pull request exists only to run the upstream checks on the exact canonical candidate. Do not merge it on GitHub.

The Nightly npm package currently stores all four shipped resource-monitor sidecars as mode 0644:

  • dist/resource-monitor/darwin-arm64/t3-resource-monitor
  • dist/resource-monitor/darwin-x64/t3-resource-monitor
  • dist/resource-monitor/linux-x64/t3-resource-monitor
  • dist/resource-monitor/win32-x64/t3-resource-monitor.exe

This candidate declares all four paths in pnpm publishConfig.executableFiles and preserves the metadata when the release CLI rewrites the publish manifest. Its focused pack test starts every fixture at 0644, performs a local pnpm pack, reads the tar headers, and requires 0755 for every path.

Reviewed predecessor cfd77f6411a530cdca3ed0afac310667acfe1c46 listed unshipped linux-arm64 and omitted shipped win32-x64. This candidate matches the release matrix.

Exact candidate:

  • Canonical Buzz base: 018d7f2775daabd2ef07898af29586915a0b7f67
  • Head: 66738b4f0323a3f867829e7ad1e351300d3acc90
  • Tree: 4e141b7d47064db2d3cece0c639adcc89fe2de39
  • Head parent: 018d7f2775daabd2ef07898af29586915a0b7f67
  • Live upstream main observed at publication: 053affbed2659f90cd1b1efaaa7a75865c4131c7

Focused checks:

  • cliManifest.test.ts: 3 tests passed
  • Local pnpm pack tar-mode assertions passed at 0755 for all four shipped paths
  • Targeted lint passed
  • Targeted format check passed
  • Server typecheck passed; non-failing suggestions were confined to untouched baseline files
  • Commit diff check passed

Canonical Buzz records:

  • Repository: 30617:4a34c131ec5cb5dd9a200bac619bbd103c0793e068fad278d1de59203d05b97d:t3code
  • Issue: 4b043ee04a2f13111e4ad4f6de072239f40319510ecc747cbda97c4df19d403e
  • Pull request: ef731045100fb7a8cbcfb444491e3fe66eb812888f2e18c460ff29d9e9b72e45
  • Buzz feature ref: refs/heads/sats/resource-monitor-modes-66738b4f0323-20260829

Model/harness: GPT-5.6 Sol via Codex CLI.


Note

Medium Risk
Changes only affect npm publish packaging for bundled binaries; behavior is covered by pack tests, but a regression could still break resource monitoring for installed CLI users.

Overview
Published t3 packages were packing all four resource-monitor sidecar binaries as non-executable (0644), which can break spawning them after install.

This PR adds publishConfig.executableFiles in apps/server/package.json for the shipped darwin (arm64/x64), linux x64, and win32 x64 monitor paths, and moves publish-time package.json rewriting into createServerCliPublishPackageJson (cliManifest.ts) so that metadata is not dropped when the release CLI resolves catalog dependencies and overrides.

cliManifest.test.ts asserts the executable list on the source manifest and generated publish manifest, and runs a local vp pm pack fixture (files start at 0644) to verify tarball entries end up at 0755.

Reviewed by Cursor Bugbot for commit 66738b4. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Preserve executable file modes for resource monitor binaries in server publish

  • Adds publishConfig.executableFiles to package.json listing four platform-specific resource monitor binaries so the npm tarball keeps mode 0755.
  • Refactors publishCmd in cli.ts to build the publish manifest via the new createServerCliPublishPackageJson factory in cliManifest.ts, which passes publishConfig through from the source package.
  • Adds tests in cliManifest.test.ts verifying the executable files appear in the packed tarball with the correct mode.
  • Behavioral Change: the generated publish package.json now includes publishConfig from the source manifest; consumers relying on its absence may see new fields.

Macroscope summarized 66738b4.

Signed-off-by: Victor Vogel <263261067+only21mil@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f7b648ee-f7db-45d1-b218-40d9b6afe46b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 29, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 66738b4

Macroscope's review found this PR approvable — This is a focused npm packaging fix that preserves executable modes for four existing resource-monitor binaries and verifies the resulting tarball metadata. It does not alter product defaults, server request behavior, schemas, deployment targets, or sensitive functionality.

You can add or adjust custom eligibility rules. Learn more.

@only21mil

Copy link
Copy Markdown
Author

Maintainer action requested: please approve the waiting fork workflows so protected CI can run on exact head 66738b4f0323a3f867829e7ad1e351300d3acc90. The CI workflow is run 33254995964 and is currently action_required. Canonical Buzz merge remains held until protected exact-head CI is terminal and passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant