fix(server): skip IDE detection in Claude probes - #8634
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8b8f1de. Configure here.
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The production change is a small, probe-scoped fix that suppresses inherited IDE-related environment flags during periodic Claude capability checks while leaving normal Claude sessions unchanged. The accompanying test verifies the isolated SDK options, with no schema, security, deployment, or customer-facing default changes. You can add or adjust custom eligibility rules. Learn more. |

What Changed
Why
Claude capability refreshes do not need IDE integration, but on Windows the auto-detection path starts
tasklist.exe | findstr.exe. Periodic refreshes can accumulate those descendants. The probe now opts out of IDE connection and installation without forcing Claude into a supported-terminal path.Closes #8575.
Testing
vp test run apps/server/src/provider/Layers/ClaudeCapabilitiesProbe.test.tsvp lint apps/server/src/provider/Layers/ClaudeProvider.ts apps/server/src/provider/Layers/ClaudeCapabilitiesProbe.test.tsvp run --filter t3 typecheckChecklist
mainModel: GPT-5.6 Sol
Harness: Codex in T3 Code