Skip to content

fix(server): skip IDE detection in Claude probes - #8634

Open
yashranaway wants to merge 2 commits into
pingdotgg:mainfrom
yashranaway:stop-claude-refresh-processes
Open

fix(server): skip IDE detection in Claude probes#8634
yashranaway wants to merge 2 commits into
pingdotgg:mainfrom
yashranaway:stop-claude-refresh-processes

Conversation

@yashranaway

@yashranaway yashranaway commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

What Changed

  • disable Claude IDE auto-connect and auto-install during periodic capability probes
  • clear any inherited terminal-forcing override from the probe environment
  • keep normal Claude sessions and their configured environment unchanged
  • assert the probe-only environment at the SDK options boundary

Why

Claude capability refreshes do not need IDE integration, but on Windows the auto-detection path starts tasklist.exe | findstr.exe. Periodic refreshes can accumulate those descendants. The probe now opts out of IDE connection and installation without forcing Claude into a supported-terminal path.

Closes #8575.

Testing

  • vp test run apps/server/src/provider/Layers/ClaudeCapabilitiesProbe.test.ts
  • vp lint apps/server/src/provider/Layers/ClaudeProvider.ts apps/server/src/provider/Layers/ClaudeCapabilitiesProbe.test.ts
  • vp run --filter t3 typecheck

Checklist

  • probe SDK options regression updated
  • normal Claude sessions are unchanged
  • targeted tests, lint, and server typecheck pass
  • rebased onto latest upstream main

Model: GPT-5.6 Sol
Harness: Codex in T3 Code

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 29d2565b-ab6e-4196-9864-d9cd68f5b7da

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 29, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8b8f1de. Configure here.

Comment thread apps/server/src/provider/Layers/ClaudeProvider.ts Outdated
@macroscopeapp

macroscopeapp Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 3ca4d0b

Macroscope's review found this PR approvable — The production change is a small, probe-scoped fix that suppresses inherited IDE-related environment flags during periodic Claude capability checks while leaving normal Claude sessions unchanged. The accompanying test verifies the isolated SDK options, with no schema, security, deployment, or customer-facing default changes.

You can add or adjust custom eligibility rules. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Periodic Claude provider refresh accumulates orphaned tasklist.exe/findstr.exe processes on Windows

1 participant