T3 Code Mobile [WIP]#2013
Open
juliusmarminge wants to merge 54 commits into
Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/client-runtimeandpackages/sharedso web and mobile can share the same behavior.Testing
Note
Medium Risk
Adds a new CI job and significant new mobile native code/config (including vendored iOS framework headers), which may introduce build/lint/tooling friction and larger repo artifacts but doesn’t change core server/web runtime here.
Overview
Introduces a new
apps/mobileExpo app scaffold with variant-basedapp.config.ts, styling setup (global.css, Metro/ Babel config), EAS build profiles, and starter docs/ignores.Adds iOS native modules for a prototype native review diff surface (
T3ReviewDiffSurface) and commits an iOS terminal module podspec that vendorsGhosttyKit.xcframework(plus third-party notices).Extends CI with a macOS
mobile_native_static_analysisjob that installsswiftlint/ktlint/detektviaapps/mobile/Brewfileand runsscripts/mobile-native-static-check.ts; updatesAGENTS.mdand formatter/linter ignore patterns to account for generated/native mobile directories.Reviewed by Cursor Bugbot for commit 399b13d. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add mobile app with native terminal, review diff, and remote environment connection support
apps/mobileas a new Expo/React Native workspace with full project scaffolding:app.config.ts,metro.config.js,package.json, Babel config, EAS build profiles, and global CSS theme tokens for light/dark mode.T3TerminalSurface) backed by vendored GhosttyKit (libghostty) on iOS and a customTextView-based fallback on Android, withonInput/onResizeevents and theme support.T3ReviewDiffSurface) with a full SwiftUIViewimplementation for rendering syntax-highlighted diffs with inline comment selection.WsTransportclass inpackages/client-runtimeproviding WebSocket RPC with reconnect backoff, streaming subscriptions, and telemetry hooks; the webWsTransportnow extends this shared base.review.getDiffPreview,terminal.attach(streaming), andsubscribeTerminalMetadata(streaming), backed byReviewServiceand expandedTerminalManagerlogic.packages/client-runtimefor VCS status, VCS refs, VCS actions, terminal sessions, shell snapshots, thread detail, checkpoint diffs, and composer path search — all backed by Effect atoms.useGitStatus, react-query mutations) across web components with VCS-agnostic equivalents (useVcsStatus, source control action hooks).DEFAULT_TERMINAL_IDfrom'default'to'term-1'and makesterminalIdrequired (no decode default) in terminal input schemas.terminal.onEventis replaced byterminal.onMetadatainEnvironmentApiandWsRpcClient; callers using the old API will break.Macroscope summarized 399b13d.