Fix GH-21999: GC inconsistency after lazy object properties ht is added to roots#22013
Draft
arnaud-lb wants to merge 1 commit into
Draft
Fix GH-21999: GC inconsistency after lazy object properties ht is added to roots#22013arnaud-lb wants to merge 1 commit into
arnaud-lb wants to merge 1 commit into
Conversation
arnaud-lb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-21999.
In the reproducer, a series of events causes a lazy object's properties ht to be a GC root [1]. The lazy object's
get_gc()handler however doesn't return the properties ht in this case, but still exposes properties to the GC. This causes properties to be visited twice.[1]:
var_dump($obj)builds the object's properties ht,zend_compare_symbol_tables()adds it to GC roots.