Skip to content

Fix GH-21986: PharData::getContent() crash on infinite recursion with…#21989

Open
devnexen wants to merge 2 commits into
php:PHP-8.4from
devnexen:gh21986
Open

Fix GH-21986: PharData::getContent() crash on infinite recursion with…#21989
devnexen wants to merge 2 commits into
php:PHP-8.4from
devnexen:gh21986

Conversation

@devnexen
Copy link
Copy Markdown
Member

@devnexen devnexen commented May 8, 2026

… symlinks.

The entries being unbounded when cycling through them, it blows the stack.

…ith symlinks.

The entries being unbounded when cycling through them, it blows the
stack.
@devnexen devnexen marked this pull request as ready for review May 9, 2026 03:06
@Girgias
Copy link
Copy Markdown
Member

Girgias commented May 11, 2026

@edorian I guess this patch fixes the issue?

@devnexen note when merging up you'll need to deal with the conversion to zend_string.

@edorian
Copy link
Copy Markdown
Member

edorian commented May 11, 2026

@Girgias Works for me :)

I don't know if a warning/error here is useful.

Fixing the crash is the core thing for me. Thank you, and than you David for the fast fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segfault during ->getContent() on a phar with recursive symlinks

3 participants