fix: report total threads as gauge (#2481)#2550
Merged
Merged
Conversation
Use a Prometheus gauge for frankenphp_total_threads so reconfiguration reports the current thread count instead of accumulating values.
dunglas
approved these changes
Jul 21, 2026
alexandre-daubois
approved these changes
Jul 22, 2026
Member
|
Thank you @ousamabenyounes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #2481
frankenphp_total_threadsas a Prometheus gauge.Setinstead of accumulating withAdd.Test verification (RED -> GREEN)
RED, on
mainwith only the new regression test added:GREEN, after the fix:
Additional targeted metrics run:
Full local suite
Local environment notes:
go test ./...in a plain Go container failed before tests because native PHP/watcher headers were absent.go test -tags nowatcher ./...withphp-devreached native linking but failed because the minimal container lacked PHP link libraries.Files changed
metrics.gototalThreadsfromCountertoGaugeand useSet.metrics_test.gocaddy/caddy_test.gogauge.