fix: reboot threads on opcache reset and watcher#2364
Conversation
# Conflicts: # caddy/caddy_test.go
Signed-off-by: Marc <m@pyc.ac>
AlliBalliBaba
changed the title
|
This PR is based on the changes in #2073. Instead of calling opcache sirextly, we just reset the whole php runtime. I haven't testes the additional overhead yet or the impact on file watching, but it might be a cleaner aolution, bypassing opcache race conditions entirely. |
|
When measuring with real-life projects, restart time slows down about 4x from ~12ms to ~48ms. Maybe that's not significant, maybe it's too much. Would be nice to also measure the difference on Mac. |
|
What's the status of this PR and #2352? Should we merge one of them? |
|
I've not looked at the linked PR because I couldn't bother looking at the bots slop without getting questions answered or addressed properly again. This one is fairly similar to #2073 which I've tested and was/is (?) ready for review. |
3 participants
Alternative to #2073 that reboots all threads instead