Skip to content

Updated possible values for display errors INI configurations#5486

Closed
Narkunan wants to merge 382 commits into
php:masterfrom
Narkunan:display_errors-only-documents-2-values
Closed

Updated possible values for display errors INI configurations#5486
Narkunan wants to merge 382 commits into
php:masterfrom
Narkunan:display_errors-only-documents-2-values

Conversation

@Narkunan
Copy link
Copy Markdown
Contributor

@Narkunan Narkunan commented Apr 11, 2026

Fix issue #2525

Comment thread reference/errorfunc/ini.xml Outdated
Comment thread reference/errorfunc/ini.xml Outdated
Comment thread reference/errorfunc/ini.xml Outdated
@Narkunan
Copy link
Copy Markdown
Contributor Author

@lacatoire Updated PR please review it let me know if any changes needed

Comment thread reference/errorfunc/ini.xml Outdated
Comment thread reference/errorfunc/ini.xml Outdated
Comment thread reference/errorfunc/ini.xml Outdated
@Narkunan
Copy link
Copy Markdown
Contributor Author

@lacatoire Done made all suggested changes

Comment thread reference/errorfunc/ini.xml
Comment thread reference/errorfunc/ini.xml Outdated
Comment thread reference/errorfunc/ini.xml Outdated
@jordikroon
Copy link
Copy Markdown
Member

Sorry this took so long to review. Overall looks good, just some structural/style comments to make it more in consistent.

@Narkunan Narkunan requested a review from jordikroon May 16, 2026 16:09
rodrigoprimo and others added 22 commits May 17, 2026 21:43
* Add missing closing brace
* Mention all relevant fpm pm modes

The option `pm.max_children` is relevant for `pm = ondemand` too.

Co-authored-by: Jordi Kroon <jordikroon@me.com>
* Tutorial: Improved What's Next section

Co-authored-by: Louis-Arnaud <la.catoire@gmail.com>
* Document Pdo\Dblib::ATTR_DATETIME_CONVERT
* [PHP 8.5] Add new tokens, T_VOID_CAST T_PIPE
…andling (php#5014)

* gmstrftime.xml Fix example to match description and demonstrate locale handling
…hp#5483)

* proc_close: clarify termination status in regard to proc_get_status

Explain how proc_get_status may interfere with proc_close return value.

Co-authored-by: Louis-Arnaud <la.catoire@gmail.com>
* Sockets: add changelog entries for PHP 8.5 changes
* Improve Docker build process: remove  --disable-segfault-error
* add Dockerfile as a Makefile dependency, so image gets rebuilt when Dockerfile changes
* Fix hash functions changelog to mention E_WARNING

Fixes php#3480

Co-authored-by: Jordi Kroon <jordi@jordikroon.nl>
* POSIX: add changelog entries for PHP 8.5 changes

Documented in appendices/migration85, missing from per-function changelogs:

- posix_kill: ValueError on out-of-range process_id
- posix_setpgid: ValueError on out-of-range process_id/process_group_id
- posix_setrlimit: ValueError on invalid hard_limit/soft_limit
- posix_ttyname: last_error EBADF on invalid file_descriptor
- posix_isatty: E_WARNING on invalid file_descriptor
- posix_fpathconf: last_error EBADF + E_WARNING on invalid file_descriptor
Remove the SimpleXML empty-element example from the list of false values. The php-src discussion for GH-21583 settled on documenting the existing behavior rather than changing SimpleXML boolean casts.
* digit.xml: add tags, amend example, del meaningless sentences

> In this case the value is c-'A'+10 for latin lettera A-Z

and

> In this case the value is ch-'a'+10

— it looks like this text was copied aimlessly from the comment of the ICU source code file:

https://github.com/unicode-org/icu/blob/40b2ec3c3727bca975824fdb9d1f084207d535ff/icu4c/source/common/unicode/uchar.h#L4252

And these sentences, IMHO, do not make sense in the context of the PHP method description, but only `u_digit` definition:

https://github.com/unicode-org/icu/blob/40b2ec3c3727bca975824fdb9d1f084207d535ff/icu4c/source/common/uchar.cpp#L452

* digit.xml: restore `ch - 'A' + 10` but replace `ch` to `codepoint`
Co-authored-by: JDW <xs@jdw.sx>
* Mention non-serializability of Closure objects

Co-authored-by: Jordi Kroon <jordi@jordikroon.nl>
@jordikroon
Copy link
Copy Markdown
Member

Thank you @Narkunan (and my apologies for the commit history). I had troubles checking out your PR which also had to be rebased. I altered the structure a bit before approving, which you can see here: (e5ff446).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.