Updated possible values for display errors INI configurations#5486
Closed
Narkunan wants to merge 382 commits into
Closed
Updated possible values for display errors INI configurations#5486Narkunan wants to merge 382 commits into
Narkunan wants to merge 382 commits into
Conversation
lacatoire
reviewed
Apr 21, 2026
lacatoire
reviewed
Apr 21, 2026
lacatoire
reviewed
Apr 21, 2026
Contributor
Author
|
@lacatoire Updated PR please review it let me know if any changes needed |
lacatoire
reviewed
Apr 24, 2026
lacatoire
reviewed
Apr 24, 2026
lacatoire
reviewed
Apr 24, 2026
Contributor
Author
|
@lacatoire Done made all suggested changes |
lacatoire
approved these changes
Apr 24, 2026
jordikroon
reviewed
May 13, 2026
jordikroon
requested changes
May 13, 2026
Member
|
Sorry this took so long to review. Overall looks good, just some structural/style comments to make it more in consistent. |
And expand on what the unsafe optimizations do and when they could potentially be applied. Co-authored-by: Gina Peter Banyard <girgias@php.net>
* Add missing closing brace * Mention all relevant fpm pm modes The option `pm.max_children` is relevant for `pm = ondemand` too. Co-authored-by: Jordi Kroon <jordikroon@me.com>
* Tutorial: Improved What's Next section Co-authored-by: Louis-Arnaud <la.catoire@gmail.com>
* Document Pdo\Dblib::ATTR_DATETIME_CONVERT
* [PHP 8.5] Add new tokens, T_VOID_CAST T_PIPE
…andling (php#5014) * gmstrftime.xml Fix example to match description and demonstrate locale handling
…hp#5483) * proc_close: clarify termination status in regard to proc_get_status Explain how proc_get_status may interfere with proc_close return value. Co-authored-by: Louis-Arnaud <la.catoire@gmail.com>
* Sockets: add changelog entries for PHP 8.5 changes
* Improve Docker build process: remove --disable-segfault-error * add Dockerfile as a Makefile dependency, so image gets rebuilt when Dockerfile changes
* Fix hash functions changelog to mention E_WARNING Fixes php#3480 Co-authored-by: Jordi Kroon <jordi@jordikroon.nl>
* POSIX: add changelog entries for PHP 8.5 changes Documented in appendices/migration85, missing from per-function changelogs: - posix_kill: ValueError on out-of-range process_id - posix_setpgid: ValueError on out-of-range process_id/process_group_id - posix_setrlimit: ValueError on invalid hard_limit/soft_limit - posix_ttyname: last_error EBADF on invalid file_descriptor - posix_isatty: E_WARNING on invalid file_descriptor - posix_fpathconf: last_error EBADF + E_WARNING on invalid file_descriptor
Remove the SimpleXML empty-element example from the list of false values. The php-src discussion for GH-21583 settled on documenting the existing behavior rather than changing SimpleXML boolean casts.
* digit.xml: add tags, amend example, del meaningless sentences > In this case the value is c-'A'+10 for latin lettera A-Z and > In this case the value is ch-'a'+10 — it looks like this text was copied aimlessly from the comment of the ICU source code file: https://github.com/unicode-org/icu/blob/40b2ec3c3727bca975824fdb9d1f084207d535ff/icu4c/source/common/unicode/uchar.h#L4252 And these sentences, IMHO, do not make sense in the context of the PHP method description, but only `u_digit` definition: https://github.com/unicode-org/icu/blob/40b2ec3c3727bca975824fdb9d1f084207d535ff/icu4c/source/common/uchar.cpp#L452 * digit.xml: restore `ch - 'A' + 10` but replace `ch` to `codepoint`
Co-authored-by: JDW <xs@jdw.sx>
* Mention non-serializability of Closure objects Co-authored-by: Jordi Kroon <jordi@jordikroon.nl>
jordikroon
added a commit
that referenced
this pull request
May 17, 2026
Member
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #2525