Automatically generated files must self-declare#317
Merged
Conversation
Member
|
I believe the title of this PR should have been "Automatically generated files must self-declare." just like the commit. Is "thenselfs" a typo? |
Member
Author
English is not my first language. Tried to be fancy, but failed. Changing. |
alfsb
changed the title
kamil-tekiela
approved these changes
Jul 8, 2026
jordikroon
approved these changes
Jul 17, 2026
Member
|
This looks good to me. Fine if you merge it now imho. It's kinda straightforward. |
Member
Author
|
I will go for it, merging today. There are four wide projects in the works (8.5 changes, manual split, entity conversion, xi:fallback), and having as few PRs open as possible is an objective in itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a small change, but I will wait at least two weeks for reviews and comments, as this is not a file I know well.