feat(ui): improve Request disclosures, body limits, history navigation, and table spacing. - #29
Conversation
…n, and table spacing.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (8)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (4)
🧰 Additional context used🪛 PHPMD (2.15.0)tests/Panel/Request/RequestSectionRendererTest.php[warning] 17-391: The class RequestSectionRendererTest has 14 public methods. Consider refactoring RequestSectionRendererTest to keep number of public methods under 10. (undefined) (TooManyPublicMethods) [error] 220-220: Avoid using static access to class '\PHPForge\Debug\Panel\Request\RequestSectionRenderer' in method 'testRenderSectionUsesCollapsedDisclosureWhenSectionIsEmpty'. (undefined) (StaticAccess) src/Panel/Request/RequestSectionRenderer.php[error] 23-204: The class RequestSectionRenderer has a coupling between objects value of 19. Consider to reduce the number of dependencies under 13. (undefined) (CouplingBetweenObjects) [error] 93-93: Avoid using static access to class '\PHPForge\Debug\Helper\Disclosure' in method 'renderSection'. (undefined) (StaticAccess) tests/Capture/CapturePolicyTest.php[warning] 17-330: The class CapturePolicyTest has 19 public methods. Consider refactoring CapturePolicyTest to keep number of public methods under 10. (undefined) (TooManyPublicMethods) 🔇 Additional comments (8)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR updates Request section rendering, adds access to the configured capture body limit, synchronizes Request navigation links with history-cursor selection, adjusts tab-panel spacing, and records these UI changes in the changelog. ChangesRequest UI and navigation
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The PR adds request disclosure improvements, exposes the configured body limit, synchronizes history navigation, and adjusts table spacing without changing enforcement or navigation safety. No actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 27.78% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 18 functions across 6 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 1744 1745 +1
===========================================
Files 141 141
Lines 7065 7065
===========================================
Hits 7065 7065 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pull Request