Conversation
… visible The working set selection highlight is an absolutely positioned marker div that only moves when a selectionChanged event fires. On startup the working set container gets the working-set-hidden class (the showWorkingSet pref is read before it is defined), so the session-restore file open positions the marker while the container is display:none - every offset computes to 0 and the marker parks on the first row. The same stale marker happens when the current file changes while the working set is hidden via the showWorkingSet pref or while another sidebar tab (e.g. AI) is active. Add WorkingSetView.refreshSelection() which recomputes the selection marker and scrolls the selected item into view, and call it when the showWorkingSet pref un-hides the container and when switching back to the files sidebar tab. Note refresh() cannot be used for this as it restores the pre-redraw scrollTop, which reads 0 on hidden elements and would undo the scroll-into-view. Adds integration tests for both paths in mainview:WorkingSetView. Claude-Session: https://claude.ai/code/session_018BpQ3Z7w4H2U5qrPGWYRWB
…tching The file tree and editor tab bar switch files on mouse down, but the working set only switched on mouse up, making it feel slow. Open the file immediately on left-button press (unless the press is on the close icon) and skip the duplicate open in the mouse up drop handler. Right/middle click paths already resolved at mouse down and are unchanged; close via the close icon still happens on mouse up without selecting the file. A drag now makes the pressed item the current file as soon as it is pressed, consistent with dragging tabs in other editors. Claude-Session: https://claude.ai/code/session_018BpQ3Z7w4H2U5qrPGWYRWB
…dx build
jsdoc-to-markdown copied the inline object return type
{code, stdout, stderr} verbatim into the generated heading, and
Docusaurus parses md as MDX where a bare {...} is a JSX expression -
acorn fails and the docs site build errors out. A named ExecFileResult
typedef generates a brace-free linked heading plus a property table.
Also picks up the previously uncommitted regenerated docs for
WorkingSetView.refreshSelection.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see commit descriptions