Repository navigation
Conversation
Callbacks fell back to the default library and its same-thread runner. If LGitLibrary used a TFWorker, libgit2 called them from the worker thread and crashed the VM. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
libgit2 calls such as fetch and clone block the VM on the same-thread runner, so the image cannot even repaint a progress bar. Needs the callbacks bound to LGitLibrary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
LGitLibraryrun its calls in aTFWorker, so long libgit2 operations no longer block the VM.Goal
With the same-thread runner,
git_remote_fetchand clone block the whole VM: no process runs, and a progress bar cannot repaint. With a worker, the image stays responsive. Iceberg needs this to fetch and clone in the background and show progress.Main changes
LGitLibrary>>runner, answeringTFWorker default.Depends on #125, which binds callbacks to
LGitLibrary. Without it, libgit2 calls them from the worker with the same-thread runner and crashes the VM. After changing the runner of a live image,FFIMethodRegistry resetAllis needed, because compiled callouts cache it.Measurements
mutalk clone from GitHub on macOS: 1.5 s on the same-thread runner, 7–10 s on the worker with Iceberg's current per-callback progress work, 3.1–3.5 s on the worker with a callback that does nothing, and 1.1–1.3 s on the worker with throttled progress (two runs).
allBranches× 300 took 239 ms on the same-thread runner and 593 ms on the worker, so small calls are about 2.5× slower.Known limitations
Not tested on Windows or Linux, nor in a headless image. A failing error read could still be overwritten if two processes alternate calls, and the full
Iceberg-Testspackage has not completed on the worker. OneIceGitMergeTesttest timed out once.🤖 Generated with Claude Code