Skip to content

Remove ffiCallSafely:? - #121

Closed
tinchodias wants to merge 2 commits into
Pharo15from
RmFFICallSafely
Closed

tinchodias wants to merge 2 commits into
Pharo15from
RmFFICallSafely

Conversation

@tinchodias

Copy link
Copy Markdown
Collaborator

In b546e75 I deleted from the Baseline:

postload: loader package: packageSpec
	"we need to initialize the FFICompilerPlugin as we added methods with <ffiCalloutTranslator>"
	FFICompilerPlugin initialize

The comment in such method references the 4 implementors of #ffiCallSafely: and #ffiCallSafely:options: in a trait.

And I was proposing this change. BUT I overlooked in LGitLibrary:

preMethodBuildContext: sender builder: builder spec: functionSpec

	sender method methodClass isClassSide ifTrue: [ ^ self ].

	(sender method literals includesAnyOf: #(#ffiCallSafely: #ffiCallSafely:options:))
		ifTrue: [  
					builder
						pushReceiver;
						send: #signalIfNotReady]

that uses those selectors to know that a message send must be inserted...

I guess we have to keep #ffiCallSafely: for now!

@tinchodias tinchodias closed this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant