Update bitcoind async client 0.14#1646
Open
caarloshenriq wants to merge 2 commits into
Open
Conversation
The previous constraint (>=0.10.8, <0.10.10) was a workaround for a breaking change accidentally backported into 0.10.10 upstream. Move to 0.14.0, which includes that change intentionally and is API-compatible with 0.10.10 going forward. This requires: - Passing `None` for the new `options: Option<BroadcastOptions>` parameter of `send_raw_transaction`, added in the 0.10.10/0.14.0 API change. - Raising the minimum versions of tokio-rustls (0.26.2 -> 0.26.4) and rustls (0.23.31 -> 0.23.38) in payjoin, payjoin-mailroom, and payjoin-test-utils, since bitreq (a transitive dependency of bitcoind-async-client 0.14.0) requires these minimums and direct-minimal-versions resolution fails otherwise.
Collaborator
Coverage Report for CI Build 27581963172Coverage remained the same at 85.188%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
DanGould
approved these changes
Jun 16, 2026
DanGould
left a comment
DanGould
left a comment
Member
There was a problem hiding this comment.
LGTM
On a related note, now that bitreq is pulled into payjoin-cli it seems the time has come to revisit bitreq and get that across the line, for the ~payjoin-cli-1.1 milestone by reviewing this PR and seeing a release through rust-bitcoin/corepc#516
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1642
The previous constraint (>=0.10.8, <0.10.10) was a workaround for
a breaking change accidentally backported into 0.10.10 upstream.
Move to 0.14.0.
This requires:
Nonefor the newoptions: Option<BroadcastOptions>parameter of
send_raw_transaction, added in the 0.10.10/0.14.0API change.
and rustls (0.23.31 -> 0.23.38) in payjoin, payjoin-mailroom,
and payjoin-test-utils, since bitreq (a transitive dependency of
bitcoind-async-client 0.14.0) requires these minimums and
direct-minimal-versions resolution fails otherwise.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.