Remove the retired g_actual and bend_field_actual#72
Merged
Conversation
bend.md decoupled the actual bend field from the reference one: the field the particle sees is Bn0/Kn0 of MagneticMultipoleP, defaulted from g_ref when Kn0_from_g_ref is set. Neither name is a BendP parameter any more, so drop them from the checker's vocabulary -- they were passing the spelling check in silence -- and from resolve_bend. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bend.mddecoupled the actual bend field from the reference one in pals#262: the field the particle actually sees isBn0/Kn0ofMagneticMultipoleP, defaulted fromg_ref/Bn0_refwhenKn0_from_g_refis set.g_actualandbend_field_actualare no longerBendPparameters at all.They were still in the checker's
BendPvocabulary, so a lattice using either name passed the spelling check in silence, andresolve_bendstill linked the pair through the momentum factor. Both are removed, and a lattice still carrying them is now told the names are unknown.The
Kn0_from_g_refdefaulting itself is not implemented here — this only retires the names the standard dropped. 168 tests pass.🤖 Generated with Claude Code