Upper case the BendP enum defaults#70
Merged
Merged
Conversation
bend.md now writes its enum values in upper case, matching the convention already followed by aperture.md, rf.md and fork.md. The BendP entries in kGroupDefaults were the last two lower case values in the table, so the expanded lattice held `ref_geometry: arc` where every other group held an upper case default. The checker validates key names, never values, so nothing else in the library reads these; the bookkeeper test that pins the materialized defaults is updated alongside. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bend.md now writes its enum values in upper case, matching the convention
already followed by aperture.md, rf.md and fork.md. The BendP entries in
kGroupDefaults were the last two lower case values in the table, so the
expanded lattice held
ref_geometry: arcwhere every other group held anupper case default.
The checker validates key names, never values, so nothing else in the
library reads these; the bookkeeper test that pins the materialized
defaults is updated alongside.
🤖 Generated with Claude Code